fix(search): compute dataset schema properly #1380

frascuchon · 2022-04-05T18:03:07Z

A wrong dataset schema computation makes es query won't be built properly with nested fields.

dcfidalgo

💯 Just one inline comment

tests/conftest.py

codecov · 2022-04-05T20:56:07Z

Codecov Report

Merging #1380 (c0fe483) into master (7580d03) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
+ Coverage   94.24%   94.41%   +0.17%     
==========================================
  Files         130      130              
  Lines        5873     5877       +4     
==========================================
+ Hits         5535     5549      +14     
+ Misses        338      328      -10

Flag	Coverage Δ
pytest	`94.41% <100.00%> (+0.17%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/rubrix/server/tasks/commons/dao/dao.py	`98.77% <100.00%> (+1.28%)`	⬆️
src/rubrix/server/tasks/search/query_builder.py	`100.00% <0.00%> (+13.55%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b03ebb...c0fe483. Read the comment docs.

…1380) * fix(search): compute dataset schema properly * test: prevent loguru not installed error * test: fix huggingface_hub version (cherry picked from commit 670ab7d)

fix(search): compute dataset schema properly

0df27f0

frascuchon requested review from dvsrepo and dcfidalgo April 5, 2022 18:03

frascuchon self-assigned this Apr 5, 2022

frascuchon added type: bug Indicates an unexpected problem or unintended behavior area: server Indicates that an issue or pull request is related to the server labels Apr 5, 2022

frascuchon added this to In progress in Release via automation Apr 5, 2022

dcfidalgo previously approved these changes Apr 5, 2022

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

Release automation moved this from In progress to Review OK Apr 5, 2022

test: prevent loguru not installed error

e3b3fac

frascuchon dismissed dcfidalgo’s stale review via e3b3fac April 5, 2022 20:02

frascuchon force-pushed the bugfixes/apply-nested-search-on-advanced-query-dsl branch from 30cf1a0 to e3b3fac Compare April 5, 2022 20:02

test: fix huggingface_hub version

c0fe483

frascuchon requested a review from dcfidalgo April 6, 2022 08:11

dcfidalgo approved these changes Apr 6, 2022

View reviewed changes

frascuchon merged commit 670ab7d into master Apr 6, 2022

Release automation moved this from Review OK to Ready to DEV QA Apr 6, 2022

frascuchon deleted the bugfixes/apply-nested-search-on-advanced-query-dsl branch April 6, 2022 09:08

frascuchon moved this from Ready to DEV QA to Approved DEV QA in Release Apr 11, 2022

frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Apr 11, 2022

frascuchon moved this from Ready to Release QA to Approved Release QA in Release Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(search): compute dataset schema properly #1380

fix(search): compute dataset schema properly #1380

frascuchon commented Apr 5, 2022

dcfidalgo left a comment

codecov bot commented Apr 5, 2022

fix(search): compute dataset schema properly #1380

fix(search): compute dataset schema properly #1380

Conversation

frascuchon commented Apr 5, 2022

dcfidalgo left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 5, 2022

Codecov Report