Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When uploading text for TokenClassificationRecord if a word whose suffix matched the following word, the two words will be shown concatenated without a space in between #1383

Closed
coreyelowsky opened this issue Apr 6, 2022 · 1 comment · Fixed by #1418
Closed

When uploading text for TokenClassificationRecord if a word whose suffix matched the following word, the two words will be shown concatenated without a space in between #1383

coreyelowsky opened this issue Apr 6, 2022 · 1 comment · Fixed by #1418
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@coreyelowsky
Copy link

See below how when an example like "This is" is in the text, where the suffix of the previous word matches the following word, then the two words are not shown with a space in between. Below this, I show the original text and the tokens.

Screen Shot 2022-04-05 at 11 43 28 PM

Screen Shot 2022-04-05 at 11 44 00 PM
@coreyelowsky coreyelowsky added the type: bug Indicates an unexpected problem or unintended behavior label Apr 6, 2022
@Amelie-V
Copy link
Member

Amelie-V commented Apr 6, 2022

let's check that together @leiyre

@coreyelowsky coreyelowsky mentioned this issue Apr 15, 2022
Closed
@frascuchon frascuchon added this to Backlog in Release via automation Apr 19, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Apr 19, 2022
leiyre added a commit that referenced this issue Apr 19, 2022
@leiyre
fix(#1414): Display characters between tokens words
7257d55 
fix #1414
fix #1383

This PR fixes the display of characters between duplicate words or when the suffix matches the following word in Token Classifier
@leiyre leiyre mentioned this issue Apr 19, 2022
Merged
frascuchon pushed a commit that referenced this issue Apr 19, 2022
@leiyre @frascuchon
fix(#1414): Display characters between tokens words
deb0799 
fix #1414
fix #1383

This PR fixes the display of characters between duplicate words or when the suffix matches the following word in Token Classifier
@frascuchon frascuchon moved this from Planified to In progress in Release Apr 19, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Apr 19, 2022
Release automation moved this from Pending Review to Ready to DEV QA Apr 19, 2022
frascuchon pushed a commit that referenced this issue Apr 19, 2022
@leiyre
fix(TokenClassification): Display characters between tokens words (#1418
97ffc64 
)

This PR fixes the display of characters between duplicate words or when the suffix matches the following word in the Token Classifier

Closes #1414
Closes #1383
@frascuchon frascuchon moved this from Ready to DEV QA to Ready to Release QA in Release Apr 25, 2022
frascuchon pushed a commit that referenced this issue Apr 25, 2022
@leiyre @frascuchon
fix(TokenClassification): Display characters between tokens words (#1418
a08cd7b 
)

This PR fixes the display of characters between duplicate words or when the suffix matches the following word in the Token Classifier

Closes #1414
Closes #1383

(cherry picked from commit 97ffc64)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1414): Display characters between tokens words argilla-io/argilla
3 participants
@coreyelowsky @leiyre @Amelie-V