Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1379): show prediction score in NER #1389

Merged
merged 15 commits into from May 3, 2022
Merged

feat(#1379): show prediction score in NER #1389

merged 15 commits into from May 3, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Apr 7, 2022

closes #1379

This PR includes score in prediction tooltip, improves score filter styles and prediction highlighting in text

@leiyre leiyre requested a review from frascuchon April 7, 2022 08:54
@frascuchon
Copy link
Member

frascuchon commented Apr 7, 2022

I've included here changes to process entity-level scores as record scores if the prediction score is not defined.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1389 (054f014) into master (ba76841) will decrease coverage by 0.95%.
The diff coverage is 100.00%.

❗ Current head 054f014 differs from pull request most recent head d51c100. Consider uploading reports for the commit d51c100 to get more accurate results

@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
- Coverage   95.45%   94.50%   -0.96%     
==========================================
  Files         113      130      +17     
  Lines        5792     5894     +102     
==========================================
+ Hits         5529     5570      +41     
- Misses        263      324      +61     
Flag Coverage Δ
pytest 94.50% <100.00%> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rix/server/tasks/token_classification/api/model.py 98.20% <100.00%> (ø)
src/rubrix/client/sdk/commons/api.py 84.37% <0.00%> (-4.76%) ⬇️
src/rubrix/client/api.py 95.16% <0.00%> (-1.10%) ⬇️
src/rubrix/monitoring/_transformers.py 94.04% <0.00%> (-0.14%) ⬇️
src/rubrix/utils.py 100.00% <0.00%> (ø)
src/rubrix/__init__.py 70.58% <0.00%> (ø)
src/rubrix/server/server.py 94.33% <0.00%> (ø)
src/rubrix/monitoring/_spacy.py 92.50% <0.00%> (ø)
src/rubrix/server/security/model.py 100.00% <0.00%> (ø)
src/rubrix/client/sdk/text2text/api.py 100.00% <0.00%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba76841...d51c100. Read the comment docs.

Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must discuss last notes in issue

@frascuchon frascuchon force-pushed the feat/ner_score branch 3 times, most recently from 6989dd9 to c3b30de Compare April 26, 2022 08:57
@frascuchon frascuchon self-requested a review May 3, 2022 11:06
@frascuchon frascuchon self-requested a review May 3, 2022 11:15
@frascuchon frascuchon merged commit 3f7eec2 into master May 3, 2022
@frascuchon frascuchon deleted the feat/ner_score branch May 3, 2022 12:44
frascuchon pushed a commit that referenced this pull request May 4, 2022
(cherry picked from commit 3f7eec2)

- fix: remove wrong annotations from Token Classifier in explore view (#1451)
(cherry picked from commit 49a08c3)
frascuchon pushed a commit that referenced this pull request May 10, 2022
(cherry picked from commit 3f7eec2)

- fix: remove wrong annotations from Token Classifier in explore view (#1451)
(cherry picked from commit 49a08c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Score info] In NER
2 participants