Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1410): apply dataset name pattern to user name #1411

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

frascuchon
Copy link
Member

Closes #1410

@frascuchon frascuchon self-assigned this Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1411 (0213569) into master (0448b33) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1411      +/-   ##
==========================================
+ Coverage   94.41%   94.50%   +0.09%     
==========================================
  Files         130      130              
  Lines        5889     5898       +9     
==========================================
+ Hits         5560     5574      +14     
+ Misses        329      324       -5     
Flag Coverage Δ
pytest 94.50% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/security/model.py 100.00% <100.00%> (ø)
src/rubrix/server/commons/es_wrapper.py 87.40% <0.00%> (-0.75%) ⬇️
src/rubrix/server/datasets/service.py 97.70% <0.00%> (ø)
src/rubrix/server/server.py 94.33% <0.00%> (+12.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260d76d...0213569. Read the comment docs.

@frascuchon
Copy link
Member Author

frascuchon commented Apr 21, 2022

A custom validator with a custom error message is applied.

@dvsrepo take a look at the message, pls

@frascuchon frascuchon merged commit f53b6e7 into master Apr 25, 2022
@frascuchon frascuchon deleted the bugfixes/#1410 branch April 25, 2022 16:10
frascuchon pushed a commit that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppercase usernames cause dataset creation to fail
2 participants