Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1428): support cleanlab v2 #1436

Merged
merged 6 commits into from Apr 26, 2022
Merged

fix(#1428): support cleanlab v2 #1436

merged 6 commits into from Apr 26, 2022

Conversation

dcfidalgo
Copy link
Contributor

Fixes #1428

With this PR we support cleanlab v1 and v2. There is an issue with our default sorting method and multi-label records (cleanlab/cleanlab#243), so for now we choose a different method when using cleanlab v2 + multi-label records.

@dcfidalgo dcfidalgo self-assigned this Apr 25, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1436 (b65acbb) into master (b48b663) will decrease coverage by 0.12%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   94.50%   94.37%   -0.13%     
==========================================
  Files         130      130              
  Lines        5892     5906      +14     
==========================================
+ Hits         5568     5574       +6     
- Misses        324      332       +8     
Flag Coverage Δ
pytest 94.37% <66.66%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubrix/labeling/text_classification/label_errors.py 90.36% <66.66%> (-9.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b48b663...b65acbb. Read the comment docs.

Release automation moved this from In progress to Review OK Apr 26, 2022
@frascuchon frascuchon merged commit d927ed4 into master Apr 26, 2022
Release automation moved this from Review OK to Ready to DEV QA Apr 26, 2022
@frascuchon frascuchon deleted the fix/support_cleanlab2 branch April 26, 2022 07:55
frascuchon pushed a commit that referenced this pull request Apr 26, 2022
@frascuchon frascuchon removed this from Waiting Release in Release Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

labeling module fails with cleanlab 2.0
2 participants