Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table word splitting #1460

Closed
Amelie-V opened this issue May 5, 2022 · 7 comments · Fixed by #1469
Closed

Table word splitting #1460

Amelie-V opened this issue May 5, 2022 · 7 comments · Fixed by #1469
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
Release
Milestone
v0.15.0

Comments

@Amelie-V
Copy link
Member

Amelie-V commented May 5, 2022 •
edited

Justified text* with hyphenation. (weak supervi-sion) to improve words breaking onto a new line:

  • In the table's columns
  • In metrics
  • In filters dropdown (in/outside of tables)
  • Labels, Tags, Tokens
@Amelie-V Amelie-V created this issue from a note in Release (Backlog) May 5, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Captura de pantalla 2022-05-05 a las 10 43 57

@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Captura de pantalla 2022-05-05 a las 10 47 47

@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Another option @dcfidalgo @frascuchon @dvsrepo could be: do not allow word breaking and jump the full word to the next line. In that option the negative thing is to increase too much the height of the table line.

@Amelie-V Amelie-V changed the title Don't split words into tables Table word splitting May 5, 2022
@Amelie-V Amelie-V added type: enhancement Indicates new feature requests area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels May 5, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Captura de pantalla 2022-05-05 a las 10 56 55

Captura de pantalla 2022-05-05 a las 10 55 38

leiyre added a commit that referenced this issue May 6, 2022
@leiyre
feat(#1460): include text hyphenation
93edcd0 
closes #1460
This PR allows to separate long texts with hyphens to improve readability
@leiyre leiyre mentioned this issue May 6, 2022
Merged
@leiyre leiyre moved this from Backlog to Pending Review in Release May 9, 2022
@leiyre leiyre linked a pull request May 10, 2022 that will close this issue
feat(#1460): include text hyphenation #1469
Merged
@frascuchon frascuchon added this to the v0.15.0 milestone May 11, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented May 18, 2022 •
edited by frascuchon

QA:

It miss the "-" on word breaking in rules table : ksdckdsj.Watertechnolo-gy

In the dropdown the "-" is visible. It should be visible in any places

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-05-18 a las 15 54 35

Captura de pantalla 2022-05-18 a las 15 53 52

@frascuchon frascuchon moved this from Pending Review to In progress in Release May 18, 2022
@leiyre
Copy link
Member

leiyre commented May 19, 2022 •
edited by frascuchon

QA:

It miss the "-" on word breaking in rules table : ksdckdsj.Watertechnolo-gy

In the dropdown the "-" is visible. It should be visible in any places

In this case the css hyphen property doesn't interpret that the word can be split, the "-" has an automatic logic and it is not possible to force it for some cases.

@leiyre leiyre moved this from In progress to Pending Review in Release May 20, 2022
@frascuchon frascuchon moved this from Pending Review to Review OK in Release May 23, 2022
Release automation moved this from Review OK to Waiting Release May 23, 2022
frascuchon pushed a commit that referenced this issue May 23, 2022
@leiyre
feat(#1460): include text hyphenation (#1469)
7d1aed1
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre @frascuchon
feat(#1460): include text hyphenation (#1469)
a7dfb1a 
(cherry picked from commit 7d1aed1)
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Jun 7, 2022
frascuchon pushed a commit that referenced this issue Jun 7, 2022
@leiyre @frascuchon
feat(#1460): include text hyphenation (#1469)
ec23b2d 
(cherry picked from commit 7d1aed1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

feat(#1460): include text hyphenation argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V