Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon first. Position in table's header #1463

Closed
Amelie-V opened this issue May 5, 2022 · 2 comments · Fixed by #1473
Closed

Icon first. Position in table's header #1463

Amelie-V opened this issue May 5, 2022 · 2 comments · Fixed by #1473
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
Release
Milestone
v0.15.0

Comments

@Amelie-V
Copy link
Member

Amelie-V commented May 5, 2022 •
edited

Icon first: Invert icon and header title in all tables
@Amelie-V Amelie-V created this issue from a note in Release (Backlog) May 5, 2022
@Amelie-V Amelie-V added area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests labels May 5, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Captura de pantalla 2022-05-05 a las 11 18 06

@Amelie-V
Copy link
Member Author

Amelie-V commented May 5, 2022

Captura de pantalla 2022-05-05 a las 11 17 56

leiyre added a commit that referenced this issue May 9, 2022
@leiyre
feta(#1463): change icon position in table header
4b7be9f 
closes #1463

This PR includes icon before text in table header
@leiyre leiyre mentioned this issue May 9, 2022
Merged
@leiyre leiyre moved this from Backlog to Pending Review in Release May 9, 2022
@leiyre leiyre linked a pull request May 10, 2022 that will close this issue
feta(#1463): change icon position in table header #1473
Merged
@Amelie-V Amelie-V mentioned this issue May 10, 2022
Closed
@frascuchon frascuchon added this to the v0.15.0 milestone May 11, 2022
@Amelie-V Amelie-V changed the title Icon position [table's header] Icon first. Position in table's header May 13, 2022
@frascuchon frascuchon moved this from Pending Review to Review OK in Release May 18, 2022
Release automation moved this from Review OK to Waiting Release May 18, 2022
frascuchon pushed a commit that referenced this issue May 18, 2022
@leiyre
feat(#1463): change icon position in table header (#1473)
4316724 
This PR includes an icon before the text in the table header

Closes #1463
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre @frascuchon
feat(#1463): change icon position in table header (#1473)
54908b3 
This PR includes an icon before the text in the table header

Closes #1463

(cherry picked from commit 4316724)
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Jun 7, 2022
frascuchon pushed a commit that referenced this issue Jun 7, 2022
@leiyre @frascuchon
feat(#1463): change icon position in table header (#1473)
5172324 
This PR includes an icon before the text in the table header

Closes #1463

(cherry picked from commit 4316724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

feta(#1463): change icon position in table header argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V