Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter values should be sorted by count #1484

Closed
frascuchon opened this issue May 11, 2022 · 0 comments · Fixed by #1488
Closed

Filter values should be sorted by count #1484

frascuchon opened this issue May 11, 2022 · 0 comments · Fixed by #1488
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release
Milestone
v0.15.0

Comments

@frascuchon
Copy link
Member

Describe the bug
The filter values are not sorted by the aggregated count after a filter is applied.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the web app and open a dataset
  2. Apply a text query
  3. See that the filter values keep the original sort (without filters)

Expected behavior
Values should be sorted by aggregated count always

Screenshots
Screenshot 2022-05-11 at 12 56 44

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Rubrix Version [e.g. 0.10.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. rubrix:v0.10.0]:

Additional context
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label May 11, 2022
@frascuchon frascuchon added this to the v0.15.0 milestone May 11, 2022
@frascuchon frascuchon added this to Backlog in Release via automation May 11, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release May 11, 2022
leiyre added a commit that referenced this issue May 12, 2022
@leiyre
fix( #1484): sort filter values by count
f91d69c 
fix #1484
This PR sorts filter values by count after a filter is applied
@leiyre leiyre mentioned this issue May 12, 2022
Merged
@leiyre leiyre linked a pull request May 12, 2022 that will close this issue
fix( #1484): sort filter values by count #1488
Merged
@leiyre leiyre moved this from Planified to Pending Review in Release May 13, 2022
Release automation moved this from Pending Review to Waiting Release May 17, 2022
frascuchon pushed a commit that referenced this issue May 17, 2022
@leiyre
fix(filters): sort filter values by count (#1488)
f6ff8dc 
This PR sorts filter values by count after a filter is applied

Closes #1484
@frascuchon frascuchon reopened this May 17, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release May 19, 2022
frascuchon pushed a commit that referenced this issue May 19, 2022
@leiyre @frascuchon
fix(filters): sort filter values by count (#1488)
0987167 
This PR sorts filter values by count after a filter is applied

Closes #1484

(cherry picked from commit f6ff8dc)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

fix( #1484): sort filter values by count argilla-io/argilla
2 participants
@frascuchon @leiyre