Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1503): Count filter values when loading a dataset with a route query #1506

Merged
merged 1 commit into from May 18, 2022
Merged

fix(#1503): Count filter values when loading a dataset with a route query #1506

merged 1 commit into from May 18, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented May 18, 2022

fix #1503
This PR includes the route query filters for the filter counter calculation

@leiyre
fix(#1503): Count filter values when loading a dataset with a route q…
8e2e72a 
…uery

fix #1503
This PR includes the route query filters for the filter counter calculation
@leiyre leiyre requested a review from frascuchon May 18, 2022 10:25
frascuchon
frascuchon approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@frascuchon frascuchon merged commit 172553e into master May 18, 2022
@frascuchon frascuchon deleted the fix/count_filters_from_route_query branch May 18, 2022 16:02
frascuchon pushed a commit that referenced this pull request May 19, 2022
@leiyre @frascuchon
fix(#1503): Count filter values when loading a dataset with a route q…
43be9b8 
…uery (#1506)

This PR includes the route query filters for the filter counter calculation
Closes #1503

(cherry picked from commit 172553e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong filter count values when loading a dataset with a filter preset
2 participants
@leiyre @frascuchon