Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1517): stop background task when something happens to main thread #1519

Merged
merged 1 commit into from May 25, 2022
Merged

fix(#1517): stop background task when something happens to main thread #1519

merged 1 commit into from May 25, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented May 25, 2022 •
edited

Closes #1517

@frascuchon frascuchon requested a review from dcfidalgo May 25, 2022 14:39
@codecov
Copy link

codecov bot commented May 25, 2022 •
edited

Codecov Report

Merging #1519 (fd9b195) into master (12937c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1519   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         126      126           
  Lines        6277     6279    +2     
=======================================
+ Hits         5996     5998    +2     
  Misses        281      281
Flag Coverage Δ
pytest 95.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/api.py 96.81% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00172c4...fd9b195. Read the comment docs.

@frascuchon frascuchon merged commit c610273 into master May 25, 2022
@frascuchon frascuchon deleted the bugfixes/stop-rb-log branch May 25, 2022 15:16
frascuchon added a commit that referenced this pull request May 30, 2022
@frascuchon
fix(#1517): stop background task when something happens to main thread (
0304f40 
#1519)

Closes #1517

(cherry picked from commit c610273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcfidalgo dcfidalgo dcfidalgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stopping rb.log keep background logging thread running
2 participants
@frascuchon @dcfidalgo