Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#1514): allow ent score None and change default value to 0.0 #1521

Merged
merged 3 commits into from May 26, 2022
Merged

feat(#1514): allow ent score None and change default value to 0.0 #1521

merged 3 commits into from May 26, 2022

Conversation

dcfidalgo
Copy link
Contributor

Closes #1514

Changes the default entity score in the predictions to 0.0, and allows None values.

@dcfidalgo dcfidalgo self-assigned this May 25, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation May 25, 2022
@dcfidalgo dcfidalgo added type: bug Indicates an unexpected problem or unintended behavior client labels May 25, 2022
@dcfidalgo dcfidalgo changed the title feat: allow ent score None and change default value to 0.0 feat(#1514): allow ent score None and change default value to 0.0 May 25, 2022
@dcfidalgo dcfidalgo marked this pull request as ready for review May 26, 2022 08:55
@codecov
Copy link

codecov bot commented May 26, 2022 •
edited

Codecov Report

Merging #1521 (483e3b8) into master (c610273) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         126      126           
  Lines        6279     6280    +1     
=======================================
+ Hits         5998     5999    +1     
  Misses        281      281
Flag Coverage Δ
pytest 95.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/datasets.py 98.12% <ø> (ø)
src/rubrix/client/models.py 98.59% <ø> (ø)
src/rubrix/server/elasticseach/client_wrapper.py 85.81% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c610273...483e3b8. Read the comment docs.

@dcfidalgo dcfidalgo requested a review from frascuchon May 26, 2022 09:12
Release automation moved this from In progress to Review OK May 26, 2022
@dcfidalgo dcfidalgo merged commit 7c7c154 into master May 26, 2022
Release automation moved this from Review OK to Waiting Release May 26, 2022
@dcfidalgo dcfidalgo deleted the fix/change_default_ent_score_to_0 branch May 26, 2022 14:54
@frascuchon frascuchon removed this from Waiting Release in Release May 30, 2022
frascuchon pushed a commit that referenced this pull request May 30, 2022
@frascuchon
fix(#1514): allow ent score None and change default value to 0.0 (#1521)
0a02c70 
* feat: allow ent score None and change default value to 0.0

* fix: fix bug

* test: adapt and add tests

(cherry picked from commit 7c7c154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees

@dcfidalgo dcfidalgo

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rubrix API fails logging data when NER score is null
2 participants
@dcfidalgo @frascuchon