Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1527): check agents instead labels for predicted computation #1528

Merged
merged 3 commits into from Jun 3, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented May 31, 2022

Closes #1527

Review after #1530

@frascuchon frascuchon requested a review from dcfidalgo May 31, 2022 11:32
@frascuchon frascuchon self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1528 (ccaa46d) into master (b1658da) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ccaa46d differs from pull request most recent head ff387a1. Consider uploading reports for the commit ff387a1 to get more accurate results

@@           Coverage Diff           @@
##           master    #1528   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         131      131           
  Lines        6438     6438           
=======================================
  Hits         6142     6142           
  Misses        296      296           
Flag Coverage Δ
pytest 95.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rver/apis/v0/models/metrics/text_classification.py 100.00% <100.00%> (ø)
...ubrix/server/apis/v0/models/text_classification.py 99.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53655f5...ff387a1. Read the comment docs.

@frascuchon frascuchon force-pushed the bugfixes/resolve-1527 branch 2 times, most recently from ccaa46d to c9a16d4 Compare June 1, 2022 14:00
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@frascuchon frascuchon merged commit 2d0612d into master Jun 3, 2022
@frascuchon frascuchon deleted the bugfixes/resolve-1527 branch June 3, 2022 15:39
frascuchon added a commit that referenced this pull request Jun 6, 2022
frascuchon added a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong predicted computation for multi-label datasets
2 participants