Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): compute f1 for text classification #1530

Merged
merged 9 commits into from Jun 2, 2022

Conversation

frascuchon
Copy link
Member

No description provided.

@frascuchon frascuchon changed the title fix(metrics):/compute f1 for text classification fix(metrics): compute f1 for text classification Jun 1, 2022
@frascuchon frascuchon requested a review from dcfidalgo June 1, 2022 15:04
@frascuchon frascuchon force-pushed the bugfixes/compute-f1-for-text-classification branch from 3811436 to b8984e8 Compare June 1, 2022 15:05
@frascuchon frascuchon self-assigned this Jun 1, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jun 1, 2022
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Jun 1, 2022
dcfidalgo
dcfidalgo previously approved these changes Jun 1, 2022
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Release automation moved this from In progress to Review OK Jun 1, 2022
@frascuchon frascuchon force-pushed the bugfixes/compute-f1-for-text-classification branch from c6b84c0 to fb592eb Compare June 1, 2022 17:05
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #1530 (7f78c28) into master (b1658da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1530   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         131      131           
  Lines        6438     6439    +1     
=======================================
+ Hits         6142     6143    +1     
  Misses        296      296           
Flag Coverage Δ
pytest 95.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/metrics/helpers.py 79.59% <100.00%> (+0.42%) ⬆️
...rver/apis/v0/models/metrics/text_classification.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1658da...7f78c28. Read the comment docs.

@frascuchon frascuchon merged commit 53655f5 into master Jun 2, 2022
@frascuchon frascuchon deleted the bugfixes/compute-f1-for-text-classification branch June 2, 2022 09:50
Release automation moved this from Review OK to Waiting Release Jun 2, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jun 6, 2022
frascuchon added a commit that referenced this pull request Jun 6, 2022
frascuchon added a commit that referenced this pull request Jun 7, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants