Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Histogram not aligned in Prediction -> Score filter #1532

Closed
dcfidalgo opened this issue Jun 2, 2022 · 1 comment · Fixed by #1540
Closed

Histogram not aligned in Prediction -> Score filter #1532

dcfidalgo opened this issue Jun 2, 2022 · 1 comment · Fixed by #1540
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@dcfidalgo
Copy link
Contributor

dcfidalgo commented Jun 2, 2022 •
edited

Describe the bug
In the Prediction -> Score filter, the histogram is not aligned with the score selector.

To Reproduce
Steps to reproduce the behavior:

  1. Go to our dev env and check out the score_filter_bug dataset
  2. Try to use the Prediction -> Score filter

Expected behavior
The histogram should be aligned with the score selector.

Screenshots
Screenshot from 2022-06-02 15-34-16
In the screenshot, the filter is already applied. Scores in the most likely prediction go from 25 to roughly 47.

Environment (please complete the following information):

  • OS [e.g. iOS]: Ubuntu 20.04
  • Browser [e.g. chrome, safari]: Firefox
  • Rubrix Version [e.g. 0.10.0]: 0.15.0dev
  • ElasticSearch Version [e.g. 7.10.2]: dev environment
  • Docker Image (optional) [e.g. rubrix:v0.10.0]: -
@dcfidalgo dcfidalgo added type: bug Indicates an unexpected problem or unintended behavior area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Jun 2, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jun 2, 2022
@dcfidalgo
Copy link
Contributor Author

CC @leiyre @frascuchon

@frascuchon frascuchon moved this from Backlog to In progress in Release Jun 3, 2022
@frascuchon frascuchon mentioned this issue Jun 3, 2022
Merged
leiyre added a commit that referenced this issue Jun 6, 2022
@leiyre
fix(#1532): correct domain for filter score histogram
22f6d58 
fix #1532

This PR forces the histogram to display a correct range and domain from 0 to 1
@leiyre leiyre mentioned this issue Jun 6, 2022
Merged
Release automation moved this from In progress to Waiting Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre
fix(#1532): correct domain for filter score histogram (#1540)
c66f292 
This PR forces the histogram to display a correct range and domain from 0 to 1

Closes #1532
@frascuchon frascuchon moved this from Waiting Release to Approved DEV QA in Release Jun 6, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre @frascuchon
fix(#1532): correct domain for filter score histogram (#1540)
7478d6c 
This PR forces the histogram to display a correct range and domain from 0 to 1

Closes #1532

(cherry picked from commit c66f292)
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1532): correct domain for filter score histogram argilla-io/argilla
1 participant
@dcfidalgo