Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Predicted as" filter activates highlighting of words #1533

Closed
dcfidalgo opened this issue Jun 2, 2022 · 4 comments · Fixed by #1538 or #1544
Closed

"Predicted as" filter activates highlighting of words #1533

dcfidalgo opened this issue Jun 2, 2022 · 4 comments · Fixed by #1538 or #1544
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@dcfidalgo
Copy link
Contributor

Describe the bug
When activating the Predicted as filter, words that match the predicted as value, seem to be highlighted.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the score_filter_bug dataset in our dev env
  2. Select palestine, for example, in the "Predictions -> Predicted as" filter

Expected behavior
Only search terms should be highlighted in my understanding.

Screenshots
Screenshot from 2022-06-02 17-45-27

Environment (please complete the following information):

  • OS [e.g. iOS]: ubuntu 20.04
  • Browser [e.g. chrome, safari]: firefox/chrome
  • Rubrix Version [e.g. 0.10.0]: dev env
  • ElasticSearch Version [e.g. 7.10.2]: dev env
  • Docker Image (optional) [e.g. rubrix:v0.10.0]: dev env

Additional context
Add any other context about the problem here.
@dcfidalgo dcfidalgo added the type: bug Indicates an unexpected problem or unintended behavior label Jun 2, 2022
@dcfidalgo dcfidalgo added this to Backlog in Release via automation Jun 2, 2022
@dcfidalgo dcfidalgo added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Jun 2, 2022
@dcfidalgo
Copy link
Contributor Author

CC @leiyre @frascuchon

@frascuchon frascuchon moved this from Backlog to Planified in Release Jun 6, 2022
frascuchon added a commit that referenced this issue Jun 6, 2022
@frascuchon
fix(#1533): highlight results only when query text is provided
0af695d
@frascuchon frascuchon mentioned this issue Jun 6, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Jun 6, 2022
Release automation moved this from In progress to Waiting Release Jun 6, 2022
@frascuchon frascuchon moved this from Waiting Release to Approved DEV QA in Release Jun 6, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Jun 6, 2022
@Amelie-V
Copy link
Member

Amelie-V commented Jun 7, 2022

@leiyre
I filtered by "Palestine", then I did a search for "Palestine", so it shows me the word in pink (its okay). Then I removed the search "Palestine", and changed it for "third" and it still underlined "Palestine".

@Amelie-V
Copy link
Member

Amelie-V commented Jun 7, 2022

Captura de pantalla 2022-06-07 a las 12 27 29

@Amelie-V Amelie-V reopened this Jun 7, 2022
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Jun 7, 2022
@dcfidalgo dcfidalgo moved this from Approved Release QA to Ready to Release QA in Release Jun 7, 2022
@dcfidalgo
Copy link
Contributor Author

+1 I can reproduce it in our release env

frascuchon added a commit that referenced this issue Jun 7, 2022
@frascuchon
fix(#1533): restrict highlighted fields
7c2b321
@frascuchon frascuchon mentioned this issue Jun 7, 2022
Merged
@frascuchon frascuchon moved this from Ready to Release QA to In progress in Release Jun 7, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Jun 7, 2022
frascuchon added a commit that referenced this issue Jun 7, 2022
@frascuchon
fix(#1533): restrict highlighted fields
b2e4405
frascuchon added a commit that referenced this issue Jun 7, 2022
@frascuchon
fix(#1533): restrict highlighted fields (#1544)
ff39f7e
Release automation moved this from Pending Review to Waiting Release Jun 7, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jun 7, 2022
frascuchon added a commit that referenced this issue Jun 7, 2022
@frascuchon
fix(#1533): restrict highlighted fields
3a8b8a9
@dcfidalgo dcfidalgo moved this from Ready to Release QA to Approved Release QA in Release Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
2 participants
@dcfidalgo @Amelie-V