Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Filters] 0 is automatically marked on filtering other options #1539

Closed
leiyre opened this issue Jun 6, 2022 · 0 comments · Fixed by #1541
Closed

[UI Filters] 0 is automatically marked on filtering other options #1539

leiyre opened this issue Jun 6, 2022 · 0 comments · Fixed by #1541
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@leiyre
Copy link
Member

leiyre commented Jun 6, 2022 •
edited

When we filter an option other than 0 in the filter dropdown list, 0 is automatically marked.

**To reproduce it

  • Open the numerical filter dropdown
  • Select any numeric option other than 0

Expected behavior

  • Option 0 must be unchecked

**Environment **

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Rubrix Version [e.g. 0.10.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. rubrix:v0.10.0]:
@leiyre leiyre added the type: bug Indicates an unexpected problem or unintended behavior label Jun 6, 2022
@leiyre leiyre self-assigned this Jun 6, 2022
@leiyre leiyre added this to Backlog in Release via automation Jun 6, 2022
leiyre added a commit that referenced this issue Jun 6, 2022
@leiyre
fix(#1539): checkbox behavior with value 0
fd280ea 
fix #1539

This PR prevents that 0 is automatically checked when another option is selected in the filter.
@leiyre leiyre mentioned this issue Jun 6, 2022
Merged
@frascuchon frascuchon moved this from Backlog to In progress in Release Jun 6, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Jun 6, 2022
Release automation moved this from Pending Review to Waiting Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre
fix(#1539): checkbox behavior with value 0 (#1541)
0b9e54a 
This PR prevents that 0 is automatically checked when another option is selected in the filter.

Closes #1539
@frascuchon frascuchon moved this from Waiting Release to Approved DEV QA in Release Jun 6, 2022
@frascuchon frascuchon moved this from Approved DEV QA to Ready to Release QA in Release Jun 6, 2022
frascuchon pushed a commit that referenced this issue Jun 6, 2022
@leiyre @frascuchon
fix(#1539): checkbox behavior with value 0 (#1541)
c51031f 
This PR prevents that 0 is automatically checked when another option is selected in the filter.

Closes #1539

(cherry picked from commit 0b9e54a)
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release Jun 7, 2022
frascuchon pushed a commit that referenced this issue Jun 7, 2022
@leiyre @frascuchon
fix(#1539): checkbox behavior with value 0 (#1541)
7a0ab63 
This PR prevents that 0 is automatically checked when another option is selected in the filter.

Closes #1539

(cherry picked from commit 0b9e54a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1539): checkbox behavior with value 0 argilla-io/argilla
1 participant
@leiyre