Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Text2Text] Edit button doesn't work #1557

Closed
leiyre opened this issue Jun 13, 2022 · 0 comments · Fixed by #1558
Closed

[Text2Text] Edit button doesn't work #1557

leiyre opened this issue Jun 13, 2022 · 0 comments · Fixed by #1558
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release

Comments

@leiyre
Copy link
Member

leiyre commented Jun 13, 2022

Describe the bug
When we are in Text2Text annotation mode and we want to edit prediction, if we click on the "Edit" button nothing happens

To Reproduce
Steps to reproduce the behavior:

  1. Go to Text2Text dataset
  2. Go to annotation mode
  3. Click on "Edit" button

Expected behavior
The edit button should display an editable textarea

Environment

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Rubrix Version [e.g. 0.10.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. rubrix:v0.10.0]:
@leiyre leiyre added the type: bug Indicates an unexpected problem or unintended behavior label Jun 13, 2022
@leiyre leiyre self-assigned this Jun 13, 2022
leiyre added a commit that referenced this issue Jun 13, 2022
@leiyre
fix(#1557): Allow text editing when clicking the "edit" button
7127706 
fix #1557
This PR makes the button be reactive to the pointer event
@leiyre leiyre mentioned this issue Jun 13, 2022
Merged
@frascuchon frascuchon added this to Backlog in Release via automation Jun 13, 2022
@frascuchon frascuchon moved this from Backlog to In progress in Release Jun 13, 2022
@leiyre leiyre moved this from In progress to Pending Review in Release Jun 15, 2022
frascuchon pushed a commit that referenced this issue Jun 16, 2022
@leiyre @frascuchon
fix(#1557): allow text editing when clicking the "edit" button
89f71cc 
fix #1557
This PR makes the button be reactive to the pointer event
frascuchon pushed a commit that referenced this issue Jun 17, 2022
@leiyre
fix(#1557): allow text editing when clicking the "edit" button (#1558)
2d724cb 
This PR makes the button be reactive to the pointer event
Closes #1557
Release automation moved this from Pending Review to Waiting Release Jun 17, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jul 5, 2022
frascuchon pushed a commit that referenced this issue Jul 5, 2022
@leiyre @frascuchon
fix(#1557): allow text editing when clicking the "edit" button (#1558)
e751414 
This PR makes the button be reactive to the pointer event
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1557): Allow text editing when clicking the "edit" button argilla-io/argilla
1 participant
@leiyre