Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1557): Allow text editing when clicking the "edit" button #1558

Merged
merged 1 commit into from Jun 17, 2022

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented Jun 13, 2022

fix #1557
This PR makes the button be reactive to the pointer event

@leiyre leiyre added the type: bug Indicates an unexpected problem or unintended behavior label Jun 13, 2022
@leiyre leiyre self-assigned this Jun 13, 2022
@leiyre leiyre requested a review from frascuchon June 13, 2022 09:07
fix #1557
This PR makes the button be reactive to the pointer event
@frascuchon frascuchon force-pushed the bugfixes/edit_prediction_in_text2text branch from 7127706 to 89f71cc Compare June 16, 2022 21:17
@frascuchon frascuchon changed the base branch from master to releases/0.x June 16, 2022 21:17
Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frascuchon frascuchon merged commit 2d724cb into releases/0.x Jun 17, 2022
@frascuchon frascuchon deleted the bugfixes/edit_prediction_in_text2text branch June 17, 2022 09:47
frascuchon pushed a commit that referenced this pull request Jun 17, 2022
This PR makes the button be reactive to the pointer event
Closes #1557
frascuchon pushed a commit that referenced this pull request Jul 5, 2022
This PR makes the button be reactive to the pointer event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Text2Text] Edit button doesn't work
2 participants