New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add pip version and dockertag as parameter in the build process #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcfidalgo
added
the
type: documentation
Improvements or additions to documentation
label
Jun 13, 2022
frascuchon
reviewed
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead with the .rst
transformation for the user management tutorial.
dcfidalgo
force-pushed
the
docs/add_release_parameter_to_docs
branch
from
June 14, 2022 11:53
0e46212
to
1ba1199
Compare
frascuchon
reviewed
Jun 14, 2022
Co-authored-by: Francisco Aranda <francisco@recogn.ai>
frascuchon
approved these changes
Jun 17, 2022
frascuchon
added a commit
that referenced
this pull request
Jul 6, 2022
…#1560) * substitute pipversion and dockertag * move setup guide to markdown * remove dependency * move index to md * move advanced setup guides to md * move user-management to md * add substitutions * Apply suggestions from code review Co-authored-by: Francisco Aranda <francisco@recogn.ai> Co-authored-by: Francisco Aranda <francisco@recogn.ai> (cherry picked from commit 477f4fe)
frascuchon
added a commit
that referenced
this pull request
Jul 8, 2022
…#1560) * substitute pipversion and dockertag * move setup guide to markdown * remove dependency * move index to md * move advanced setup guides to md * move user-management to md * add substitutions * Apply suggestions from code review Co-authored-by: Francisco Aranda <francisco@recogn.ai> Co-authored-by: Francisco Aranda <francisco@recogn.ai> (cherry picked from commit 477f4fe)
frascuchon
added a commit
that referenced
this pull request
Jul 8, 2022
…#1560) * substitute pipversion and dockertag * move setup guide to markdown * remove dependency * move index to md * move advanced setup guides to md * move user-management to md * add substitutions * Apply suggestions from code review Co-authored-by: Francisco Aranda <francisco@recogn.ai> Co-authored-by: Francisco Aranda <francisco@recogn.ai> (cherry picked from commit 477f4fe)
frascuchon
added a commit
that referenced
this pull request
Jul 8, 2022
…#1560) * substitute pipversion and dockertag * move setup guide to markdown * remove dependency * move index to md * move advanced setup guides to md * move user-management to md * add substitutions * Apply suggestions from code review Co-authored-by: Francisco Aranda <francisco@recogn.ai> Co-authored-by: Francisco Aranda <francisco@recogn.ai> (cherry picked from commit 477f4fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic substitutions of pip versions and docker tags in
rst
files. But I did not manage to make it work for theuser-management.ipynb
notebook. I propose to move the content of this notebook to arst
ormd
file, since there is not too much code.@frascuchon should I proceed, or should I keep trying to make it also work for notebooks?