Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1264): discard first space after a token #1591

Merged
merged 4 commits into from Jul 6, 2022
Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jun 29, 2022

In this PR we discard from token candidates the first space after a token.

Closes #1264

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1591 (e367fbd) into master (ec6104d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
- Coverage   95.37%   95.33%   -0.05%     
==========================================
  Files         135      135              
  Lines        6426     6430       +4     
==========================================
+ Hits         6129     6130       +1     
- Misses        297      300       +3     
Flag Coverage Δ
pytest 95.33% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...brix/server/apis/v0/models/token_classification.py 98.24% <100.00%> (+0.04%) ⬆️
...ubrix/labeling/text_classification/label_errors.py 86.74% <0.00%> (-3.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9dfb89...e367fbd. Read the comment docs.

@frascuchon frascuchon marked this pull request as ready for review July 4, 2022 13:46
@frascuchon frascuchon requested a review from dvsrepo July 4, 2022 13:47
@frascuchon frascuchon changed the title fix(#1264): preprocess record tokens fix(#1264): discard first space after a token Jul 5, 2022
@frascuchon frascuchon merged commit 9fdc648 into master Jul 6, 2022
@frascuchon frascuchon deleted the bugfixes/1264 branch July 6, 2022 15:11
frascuchon added a commit that referenced this pull request Jul 6, 2022
frascuchon added a commit that referenced this pull request Jul 8, 2022
frascuchon added a commit that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TokenClassificationRecord] Alignment issues when token is a white space
2 participants