Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(token-class): adjust token spans spaces #1599

Merged
merged 3 commits into from Jul 6, 2022
Merged

feat(token-class): adjust token spans spaces #1599

merged 3 commits into from Jul 6, 2022

Conversation

frascuchon
Copy link
Member

No description provided.

@frascuchon frascuchon added type: enhancement Indicates new feature requests token-classification labels Jul 1, 2022
@frascuchon frascuchon requested a review from dcfidalgo July 1, 2022 12:03
@frascuchon frascuchon self-assigned this Jul 1, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jul 1, 2022
@codecov
Copy link

codecov bot commented Jul 1, 2022 •
edited

Codecov Report

Merging #1599 (9a80e4f) into master (9fdc648) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   95.39%   95.40%           
=======================================
  Files         135      135           
  Lines        6430     6441   +11     
=======================================
+ Hits         6134     6145   +11     
  Misses        296      296
Flag Coverage Δ
pytest 95.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...brix/server/apis/v0/models/token_classification.py 98.35% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fdc648...9a80e4f. Read the comment docs.

Release automation moved this from In progress to Review OK Jul 6, 2022
dcfidalgo
dcfidalgo previously approved these changes Jul 6, 2022
View reviewed changes
@frascuchon frascuchon merged commit b42bb6d into master Jul 6, 2022
@frascuchon frascuchon deleted the feat/trim-token-spans branch July 6, 2022 16:04
Release automation moved this from Review OK to Waiting Release Jul 6, 2022
frascuchon added a commit that referenced this pull request Jul 6, 2022
@frascuchon
feat(token-class): adjust token spans spaces (#1599)
cdf563c 
* test: add tests

(cherry picked from commit b42bb6d)
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Jul 7, 2022
frascuchon added a commit that referenced this pull request Jul 7, 2022
@frascuchon
feat(token-class): adjust token spans spaces (#1599)
830fbad 
* test: add tests

(cherry picked from commit b42bb6d)
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Jul 7, 2022
frascuchon added a commit that referenced this pull request Jul 8, 2022
@frascuchon
feat(token-class): adjust token spans spaces (#1599)
57a60ec 
* test: add tests

(cherry picked from commit b42bb6d)
frascuchon added a commit that referenced this pull request Jul 8, 2022
@frascuchon
feat(token-class): adjust token spans spaces (#1599)
d91c5b6 
* test: add tests

(cherry picked from commit b42bb6d)
frascuchon added a commit that referenced this pull request Jul 8, 2022
@frascuchon
feat(token-class): adjust token spans spaces (#1599)
0fb3576 
* test: add tests

(cherry picked from commit b42bb6d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcfidalgo dcfidalgo dcfidalgo left review comments

Assignees

@frascuchon frascuchon

Labels
type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frascuchon @dcfidalgo