Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create ds with same name in different ws and different task #1608

Conversation

frascuchon
Copy link
Member

After changes in #1572, creating a dataset with the same name as an already registered in Rubrix, in a different workspace, and with a different task, raise an error. This PR includes changes for that. It should be squashed together with #1572

@frascuchon frascuchon requested a review from dcfidalgo July 8, 2022 08:36
@frascuchon frascuchon self-assigned this Jul 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1608 (184c689) into releases/0.x (4f2c35c) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@               Coverage Diff                @@
##           releases/0.x    #1608      +/-   ##
================================================
+ Coverage         95.31%   95.33%   +0.01%     
================================================
  Files               131      131              
  Lines              6426     6429       +3     
================================================
+ Hits               6125     6129       +4     
+ Misses              301      300       -1     
Flag Coverage Δ
pytest 95.33% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/services/datasets.py 96.15% <50.00%> (-1.87%) ⬇️
...ubrix/labeling/text_classification/label_errors.py 90.36% <0.00%> (+3.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2c35c...184c689. Read the comment docs.

@frascuchon frascuchon linked an issue Jul 8, 2022 that may be closed by this pull request
@frascuchon frascuchon merged commit 4471424 into releases/0.x Jul 8, 2022
@frascuchon frascuchon deleted the bugfixes/allow-create-dataset-in-a-different-workspace branch July 8, 2022 08:54
frascuchon added a commit that referenced this pull request Jul 8, 2022
…ided (#1572, #1608)

- create ds with same name in different ws and different task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datasets] admin users cannot fetch dataset without workspace
2 participants