Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(#): implement christopher comments #1609

Merged
merged 1 commit into from Jul 8, 2022

Conversation

dcfidalgo
Copy link
Contributor

This PR implements comments by @chschroeder, thanks a lot Christopher!

Something for the future: I think ideally we should have a conceptual guide on active learning and just reference this guide in the tutorials. We do this for the weak supervision tutorials, more or less.

Closes #1601

@dcfidalgo dcfidalgo self-assigned this Jul 8, 2022
@dcfidalgo dcfidalgo added the type: documentation Improvements or additions to documentation label Jul 8, 2022
@dcfidalgo dcfidalgo added this to In progress in Release via automation Jul 8, 2022
@dcfidalgo dcfidalgo requested a review from frascuchon July 8, 2022 09:45
Release automation moved this from In progress to Review OK Jul 8, 2022
@frascuchon frascuchon merged commit 090f8a8 into master Jul 8, 2022
@frascuchon frascuchon deleted the docs/small_text_listeners_comments branch July 8, 2022 14:16
Release automation moved this from Review OK to Waiting Release Jul 8, 2022
frascuchon pushed a commit that referenced this pull request Jul 8, 2022
* docs: add tutorial

* docs: remove as_pandas argument

* docs: latest version of code

* docs: add simulation with transformers

* chorse: run black

* docs: adapt tutorial to query_params

* docs: start fleshing out

* docs: first complete version

* docs: remove simulation and sklearn part

* docs: add simulation bonus

* docs: add screenshot

* docs: add to gallery

* docs: add emoji

* docs: add video

* docs: remove bonus: sklearn-transformers comparison

* docs: fix listener decorator link

(cherry picked from commit f254e8d)

docs: implement christopher comments (#1609)

(cherry picked from commit 090f8a8)

Closes #1601,#421
@frascuchon frascuchon removed this from Waiting Release in Release Jul 8, 2022
frascuchon pushed a commit that referenced this pull request Jul 8, 2022
#1609)

* docs: add tutorial

* docs: remove as_pandas argument

* docs: latest version of code

* docs: add simulation with transformers

* chorse: run black

* docs: adapt tutorial to query_params

* docs: start fleshing out

* docs: first complete version

* docs: remove simulation and sklearn part

* docs: add simulation bonus

* docs: add screenshot

* docs: add to gallery

* docs: add emoji

* docs: add video

* docs: remove bonus: sklearn-transformers comparison

* docs: fix listener decorator link

(cherry picked from commit f254e8d)

docs: implement christopher comments

(cherry picked from commit 090f8a8)

Closes #1601,#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Listeners] include the active learning tutorial:
2 participants