Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing friendships - Improve record card visibility #1624

Closed
Amelie-V opened this issue Jul 20, 2022 · 2 comments · Fixed by #1638
Closed

Spacing friendships - Improve record card visibility #1624

Amelie-V opened this issue Jul 20, 2022 · 2 comments · Fixed by #1638
Assignees
@leiyre @Amelie-V
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
Release
Milestone
v0.17.0

Comments

@Amelie-V
Copy link
Member

Amelie-V commented Jul 20, 2022 •
edited

Is your feature request related to a problem? Please describe.

We are currently improving our space system in Figma and we'll implement it in various batches.
This issue aim to adapt spaces to improve the records cards visualisation

Describe the solution you'd like

https://uxdesign.cc/ui-cheat-sheet-spacing-friendships-e37a6fccc407

Apply the 8 magic number and spacing friendship concept
8px: between cards
16px: between global action bar and record card
32px: around search box

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.
@Amelie-V Amelie-V added type: enhancement Indicates new feature requests area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Jul 20, 2022
@Amelie-V Amelie-V added this to the v0.17.0 milestone Jul 20, 2022
@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-07-20 a las 12 06 57

Captura de pantalla 2022-07-20 a las 11 55 58

@Amelie-V Amelie-V changed the title Spacing friendships - Dataset layout Spacing friendships - Improve record card visibility Jul 20, 2022
@Amelie-V Amelie-V added this to Backlog in Release via automation Jul 20, 2022
@Amelie-V Amelie-V moved this from Backlog to Planified in Release Jul 20, 2022
@frascuchon
Copy link
Member

We must take into account the number of visible records after the spacing. It should be nice to find a trade-off between record visibility and batch revision/annotation.

Anyway, this is just a comment.

@frascuchon frascuchon modified the milestones: v0.17.0, v0.16.0 Jul 21, 2022
leiyre added a commit that referenced this issue Jul 26, 2022
@leiyre
style: Improve card spacing
b7a39f0 
closes #1624

This PR applies the 8px spacing rule to the header of filters, global actions and cards.
@leiyre leiyre mentioned this issue Jul 26, 2022
Merged
frascuchon pushed a commit that referenced this issue Jul 28, 2022
@leiyre
style: Improve card spacing (#1638)
c79d7fe 
This PR applies the 8px spacing rule to the header of filters, global actions and cards.

Closes #1624
Release automation moved this from Planified to Waiting Release Jul 28, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Aug 18, 2022
frascuchon pushed a commit that referenced this issue Aug 18, 2022
@leiyre @frascuchon
style: Improve card spacing (#1638)
7425e39 
This PR applies the 8px spacing rule to the header of filters, global actions and cards.

Closes #1624

(cherry picked from commit c79d7fe)
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Aug 19, 2022
frascuchon pushed a commit that referenced this issue Aug 22, 2022
@leiyre @frascuchon
style: Improve card spacing (#1638)
fd4016a 
This PR applies the 8px spacing rule to the header of filters, global actions and cards.

Closes #1624

(cherry picked from commit c79d7fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: enhancement Indicates new feature requests
Projects
No open projects
Release
Approved Release QA
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

style: Improve card spacing argilla-io/argilla
3 participants
@frascuchon @leiyre @Amelie-V