New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: reusing the inner httpx
client
#1640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
changed the title
Perf/reusing httpx client on load
perf: reusing Jul 26, 2022
httpx
client on load
frascuchon
changed the title
perf: reusing
perf: reusing the inner Jul 26, 2022
httpx
client on loadhttpx
client
Codecov Report
@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
- Coverage 95.59% 95.52% -0.08%
==========================================
Files 133 133
Lines 6339 6346 +7
==========================================
+ Hits 6060 6062 +2
- Misses 279 284 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
frascuchon
added a commit
that referenced
this pull request
Aug 18, 2022
frascuchon
added a commit
that referenced
this pull request
Aug 22, 2022
frascuchon
added a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the changes to the API client to reuse the internal
httpx
client for several requests. These changes could help to mitigate some reported errors related to this issue encode/httpx#1027Also, stop creating new threads after the
utils.py::setup_loop_in_thread
is called.Closes #1646
Refs: The Slack thread