Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Weak labeling] Save rules with symbols #1645

Closed
leiyre opened this issue Jul 27, 2022 · 0 comments · Fixed by #1649
Closed

[Weak labeling] Save rules with symbols #1645

leiyre opened this issue Jul 27, 2022 · 0 comments · Fixed by #1649
Assignees
@leiyre
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
Release
Milestone
v0.17.0

Comments

@leiyre
Copy link
Member

leiyre commented Jul 27, 2022

Describe the bug
An error is displayed when saving rules with symbols

To Reproduce
Steps to reproduce the behavior:

  1. Go to Text Classifier
  2. Click on Weak labeling
  3. Search text with symbols
  4. See error

Expected behavior
It must be possible to save without errors

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Rubrix Version [e.g. 0.10.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. rubrix:v0.10.0]:

Additional context
Add any other context about the problem here.
@leiyre leiyre added the type: bug Indicates an unexpected problem or unintended behavior label Jul 27, 2022
@leiyre leiyre self-assigned this Jul 27, 2022
@leiyre leiyre added this to Backlog in Release via automation Jul 28, 2022
@leiyre leiyre moved this from Backlog to Planified in Release Jul 28, 2022
@leiyre leiyre moved this from Planified to In progress in Release Jul 28, 2022
leiyre added a commit that referenced this issue Jul 28, 2022
@leiyre
fix: Encode rule name in Weak Labeling API requests
1803d23 
closes #1645

This PR encodes the rule name to avoid errors in the API request
@leiyre leiyre mentioned this issue Jul 28, 2022
Merged
@leiyre leiyre moved this from In progress to Pending Review in Release Jul 28, 2022
@leiyre leiyre linked a pull request Jul 28, 2022 that will close this issue
fix: Encode rule name in Weak Labeling API requests #1649
Merged
@frascuchon frascuchon added this to the v0.17.0 milestone Jul 28, 2022
frascuchon pushed a commit that referenced this issue Jul 28, 2022
@leiyre
fix: Encode rule name in Weak Labeling API requests (#1649)
4634df8 
This PR encodes the rule name to avoid errors in the API request

Closes #1645
@frascuchon frascuchon moved this from Pending Review to Review OK in Release Aug 3, 2022
Release automation moved this from Review OK to Waiting Release Aug 3, 2022
@frascuchon frascuchon reopened this Aug 3, 2022
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Aug 3, 2022
@leiyre leiyre moved this from Ready to Release QA to Approved Release QA in Release Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Milestone
v0.17.0
Development

Successfully merging a pull request may close this issue.

fix: Encode rule name in Weak Labeling API requests argilla-io/argilla
2 participants
@frascuchon @leiyre