Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata limit check includes elastic subfields #1699

Closed
frascuchon opened this issue Aug 29, 2022 · 0 comments · Fixed by #1700
Closed

Metadata limit check includes elastic subfields #1699

frascuchon opened this issue Aug 29, 2022 · 0 comments · Fixed by #1700
Assignees
Labels
type: bug Indicates an unexpected problem or unintended behavior
Milestone

Comments

@frascuchon
Copy link
Member

Discussed in https://github.com/recognai/rubrix/discussions/1698

Originally posted by hanshupe August 26, 2022
I got a MetadataLimitExceededError, saying that the metadata length exceeded 50, which was not the case.

I found this code snippet in records.py:

check_metadata_length(
            len(
                {
                    *self._es.get_field_mapping(index, "metadata.*"),
                    *[k for k in metadata_values.keys()],
                }
            )
        )

It looks like one field of my metadata is counted multiple times with different versions: description.text, description.exact, description.worldcloud, so the limit is exceeds very quickly.

  • Can someone explain why those metadata fields are created?
@frascuchon frascuchon added the type: bug Indicates an unexpected problem or unintended behavior label Aug 29, 2022
@frascuchon frascuchon self-assigned this Aug 29, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Aug 29, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Aug 29, 2022
@frascuchon frascuchon linked a pull request Aug 31, 2022 that will close this issue
@frascuchon frascuchon moved this from Planified to In progress in Release Sep 1, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Sep 8, 2022
Release automation moved this from Pending Review to Waiting Release Sep 8, 2022
frascuchon added a commit that referenced this issue Sep 8, 2022
* fix: exclude subfields from metadata mapping

* chore: clean imports

* tests: fix tests

Closes #1699
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release Sep 8, 2022
@frascuchon frascuchon moved this from Ready to Release QA to Approved Release QA in Release Sep 8, 2022
@frascuchon frascuchon removed this from Approved Release QA in Release Sep 13, 2022
@frascuchon frascuchon added this to the v0.18.0 milestone Sep 13, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
frascuchon added a commit that referenced this issue Sep 27, 2022
* fix: exclude subfields from metadata mapping

* chore: clean imports

* tests: fix tests

Closes #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant