Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Metadata limits): exclude subfields from mappings #1700

Merged
merged 3 commits into from Sep 1, 2022

Conversation

frascuchon
Copy link
Member

Closes #1699

@frascuchon frascuchon self-assigned this Aug 31, 2022
@frascuchon frascuchon linked an issue Aug 31, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 95.61% // Head: 95.61% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3f8841f) compared to base (7e0d915).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           releases/0.x    #1700   +/-   ##
=============================================
  Coverage         95.61%   95.61%           
=============================================
  Files               131      131           
  Lines              6379     6387    +8     
=============================================
+ Hits               6099     6107    +8     
  Misses              280      280           
Flag Coverage Δ
pytest 95.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/daos/records.py 96.22% <ø> (ø)
src/rubrix/server/elasticseach/client_wrapper.py 87.57% <100.00%> (+0.64%) ⬆️
src/rubrix/server/security/model.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit fc6658c into releases/0.x Sep 1, 2022
@frascuchon frascuchon deleted the bugfixes/compute-metadata-fields-limit branch September 1, 2022 11:06
frascuchon added a commit that referenced this pull request Sep 8, 2022
* fix: exclude subfields from metadata mapping

* chore: clean imports

* tests: fix tests

Closes #1699
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
frascuchon added a commit that referenced this pull request Sep 27, 2022
* fix: exclude subfields from metadata mapping

* chore: clean imports

* tests: fix tests

Closes #1699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata limit check includes elastic subfields
1 participant