New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve many typos, clean up via pre-commit
#1701
Conversation
Found via codespell (would recommend)
Hi @tomaarsen and thanks so much for your work. If you don't mind, I will create a separate PR including only fixes about the |
Seems good! If you ever run into issues with https://pre-commit.ci/, you can defer to their now-deprecated GitHub action, which can be used like so: I did a tiny bit of testing with your approach from #1703, but had not gotten around to applying it fully. I'll be following this to see if it works well for Rubrix! |
Thanks @tomaarsen Finally, I could configure properly the pre-commit checks so new changes in the repo will auto-fix by the pre-commit.ci module. Maybe you find some conflict error if you try to bring changes from the master master branch. |
Glad you got it working! Do you need anything from me to get this PR ready for merging? |
I don't think so. I will tell you if I need your help. Thanks!! |
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
) * chore: Resolve many typos in documentation, comments and tutorials Found via codespell (would recommend) * chore: run pre-commit --all to clean up all files (cherry picked from commit 5d9340b)
Hello!
Pull request overview
codespell
and fix them in comments, the README, documentation and tutorials.pre-commit run --all
to perform reformatting, EOF fixing, removing redundant whitespace, etc.Note
Surprisingly, running
pre-commit
introduced many changes, causing this PR to be a bit cluttered. Because of this, I'd recommend reviewing the two commits separately.