Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connection] Allow customize client by extra args #1706

Closed
frascuchon opened this issue Sep 7, 2022 · 0 comments · Fixed by #1715
Closed

[Connection] Allow customize client by extra args #1706

frascuchon opened this issue Sep 7, 2022 · 0 comments · Fixed by #1715
Assignees
@frascuchon
Labels
type: community request Indicates a feature requested by someone outside of the Argilla organization type: enhancement Indicates new feature requests
Milestone
v0.18.0

Comments

@frascuchon
Copy link
Member

Sometimes client configuration needs extra headers (normally by security restrictions)

We can provide a way to customize the inner client HTTP connection by passing some extra arguments to rb.init method:

rb.init(url,api_key=...,extra_headers=...)
@frascuchon frascuchon added type: enhancement Indicates new feature requests client type: community request Indicates a feature requested by someone outside of the Argilla organization labels Sep 7, 2022
@frascuchon frascuchon self-assigned this Sep 7, 2022
@frascuchon frascuchon transferred this issue from another repository Sep 7, 2022
@frascuchon frascuchon added this to Backlog in Release via automation Sep 7, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Sep 7, 2022
@frascuchon frascuchon removed this from Planified in Release Sep 13, 2022
@frascuchon frascuchon added this to the v0.18.0 milestone Sep 13, 2022
@frascuchon frascuchon mentioned this issue Sep 13, 2022
Merged
frascuchon added a commit that referenced this issue Sep 22, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
994494f 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706
frascuchon added a commit that referenced this issue Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
a6c7af8 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
894b695 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
f3fc647 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
13b5b10 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Sep 29, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
b19cf15 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Sep 30, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
9abf784 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Oct 3, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
d973eac 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Oct 4, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
e60b7bd 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Oct 5, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
eb1c4d9 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this issue Oct 5, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
79f0529 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
type: community request Indicates a feature requested by someone outside of the Argilla organization type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging a pull request may close this issue.

feat(Client): expose client extra headers in init function argilla-io/argilla
1 participant
@frascuchon