feat(Datasets): restrict dataset deletion only to creators and super-users #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvsrepo
requested changes
Sep 13, 2022
Codecov ReportBase: 95.66% // Head: 95.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
- Coverage 95.66% 95.64% -0.03%
==========================================
Files 147 147
Lines 6720 6722 +2
==========================================
Hits 6429 6429
- Misses 291 293 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>
frascuchon
commented
Sep 13, 2022
frascuchon
added a commit
that referenced
this pull request
Sep 27, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270)
frascuchon
added a commit
that referenced
this pull request
Sep 27, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270)
frascuchon
added a commit
that referenced
this pull request
Sep 27, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270)
frascuchon
added a commit
that referenced
this pull request
Sep 27, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270)
frascuchon
added a commit
that referenced
this pull request
Sep 29, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270)
frascuchon
added a commit
that referenced
this pull request
Sep 30, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270) fix: handle separately 401 and 403 api errors in UI (#1740) Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation. This PR handles separate authentication errors (401) and forbidden errors (403). We should find a better way to handle error codes and info in general.
frascuchon
added a commit
that referenced
this pull request
Oct 3, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270) fix: handle separately 401 and 403 api errors in UI (#1740) Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation. This PR handles separate authentication errors (401) and forbidden errors (403). We should find a better way to handle error codes and info in general.
frascuchon
added a commit
that referenced
this pull request
Oct 4, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270) fix: handle separately 401 and 403 api errors in UI (#1740) Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation. This PR handles separate authentication errors (401) and forbidden errors (403). We should find a better way to handle error codes and info in general.
frascuchon
added a commit
that referenced
this pull request
Oct 5, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270) fix: handle separately 401 and 403 api errors in UI (#1740) Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation. This PR handles separate authentication errors (401) and forbidden errors (403). We should find a better way to handle error codes and info in general.
frascuchon
added a commit
that referenced
this pull request
Oct 5, 2022
…users (#1713) * feat(Datasets): restrict dataset deletion only to creators and super-users * tests: add tests for datasets deletion check * chore: improve deletion error message Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> * Format long strings Co-authored-by: Daniel Vila Suero <daniel@recogn.ai> (cherry picked from commit c5ab270) fix: handle separately 401 and 403 api errors in UI (#1740) Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation. This PR handles separate authentication errors (401) and forbidden errors (403). We should find a better way to handle error codes and info in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes restrictions on dataset deletion. Only datasets the creator or super-users (with full workspaces access) can delete datasets
@dvsrepo just review the error message, pls