Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Client): expose client extra headers in init function #1715

Merged
merged 4 commits into from Sep 22, 2022
Merged

feat(Client): expose client extra headers in init function #1715

merged 4 commits into from Sep 22, 2022

Conversation

frascuchon
Copy link
Member

Closes #1706

@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited

Codecov Report

Base: 95.68% // Head: 95.00% // Decreases project coverage by -0.67% ⚠️

Coverage data is based on head (eeb7106) compared to base (a9076dc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1715      +/-   ##
==========================================
- Coverage   95.68%   95.00%   -0.68%     
==========================================
  Files         147      148       +1     
  Lines        6722     6808      +86     
==========================================
+ Hits         6432     6468      +36     
- Misses        290      340      +50
Flag Coverage Δ
pytest 95.00% <100.00%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/api.py 96.95% <100.00%> (+0.08%) ⬆️
src/rubrix/client/datasets.py 85.19% <0.00%> (-12.47%) ⬇️
...ubrix/labeling/text_classification/label_errors.py 86.74% <0.00%> (-3.62%) ⬇️
src/rubrix/__init__.py 100.00% <0.00%> (ø)
src/rubrix/_version.py 100.00% <0.00%> (ø)
src/rubrix/server/routes.py 100.00% <0.00%> (ø)
src/rubrix/metrics/models.py 87.50% <0.00%> (ø)
src/rubrix/metrics/commons.py 100.00% <0.00%> (ø)
src/rubrix/metrics/helpers.py 79.59% <0.00%> (ø)
src/rubrix/monitoring/base.py 73.52% <0.00%> (ø)
... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon modified the milestone: v0.18.0 Sep 16, 2022
@frascuchon
Copy link
Member Author

@dvsrepo just review the arg naming and doc string, pls.

https://github.com/recognai/rubrix/pull/1715/files#diff-6b8ac5652e75b4d467e0bab452972dd441064ffc7a694a201fd3fb4b0530ba7eR116

dvsrepo
dvsrepo reviewed Sep 21, 2022
View reviewed changes
src/rubrix/client/api.py Outdated Show resolved Hide resolved
@frascuchon
Copy link
Member Author

You can also check the generated documentation: https://rubrix.readthedocs.io/en/feat-customize-client-headers/

dvsrepo
dvsrepo requested changes Sep 21, 2022
View reviewed changes
src/rubrix/client/api.py Outdated Show resolved Hide resolved
src/rubrix/client/api.py Outdated Show resolved Hide resolved
@frascuchon @dvsrepo
Apply suggestions from code review
eeb7106 
Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>
@frascuchon frascuchon merged commit 994494f into master Sep 22, 2022
@frascuchon frascuchon deleted the feat/customize-client-headers branch September 22, 2022 08:01
frascuchon added a commit that referenced this pull request Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
a6c7af8 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
894b695 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
f3fc647 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Sep 27, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
13b5b10 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Sep 29, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
b19cf15 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Sep 30, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
9abf784 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Oct 3, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
d973eac 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Oct 4, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
e60b7bd 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Oct 5, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
eb1c4d9 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
frascuchon added a commit that referenced this pull request Oct 5, 2022
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
79f0529 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvsrepo dvsrepo dvsrepo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Connection] Allow customize client by extra args
2 participants
@frascuchon @dvsrepo