Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete records feature #1737

Merged
merged 6 commits into from Sep 30, 2022
Merged

fix: delete records feature #1737

merged 6 commits into from Sep 30, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Sep 30, 2022 •
edited

Some problems detected:

  • Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
  • Fix response data when no records match for deletion

Refs #1714

@frascuchon frascuchon changed the base branch from master to releases/0.x September 30, 2022 08:57
@codecov
Copy link

codecov bot commented Sep 30, 2022 •
edited

Codecov Report

Base: 95.02% // Head: 94.97% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (d234b0b) compared to base (a8163bf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           releases/0.x    #1737      +/-   ##
================================================
- Coverage         95.02%   94.97%   -0.05%     
================================================
  Files               148      148              
  Lines              6812     6812              
================================================
- Hits               6473     6470       -3     
- Misses              339      342       +3
Flag Coverage Δ
pytest 94.97% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/api.py 96.95% <ø> (ø)
src/rubrix/client/sdk/client.py 96.42% <100.00%> (ø)
src/rubrix/server/services/storage/service.py 100.00% <100.00%> (ø)
...ubrix/labeling/text_classification/label_errors.py 86.74% <0.00%> (-3.62%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon force-pushed the bugfixes/delete-records-feature branch from 2e9cfbf to d234b0b Compare September 30, 2022 10:27
@frascuchon frascuchon merged commit d43fe87 into releases/0.x Sep 30, 2022
@frascuchon frascuchon deleted the bugfixes/delete-records-feature branch September 30, 2022 13:36
frascuchon added a commit that referenced this pull request Sep 30, 2022
@frascuchon
fix: delete records feature (#1737)
b1e365a 
Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
Refs #1714
frascuchon added a commit that referenced this pull request Sep 30, 2022
@frascuchon
feat(Datasets): delete records by query (#1721)
256d3a4 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
frascuchon added a commit that referenced this pull request Oct 3, 2022
@frascuchon
feat(Datasets): delete records by query (#1721)
f066518 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
frascuchon added a commit that referenced this pull request Oct 4, 2022
@frascuchon
feat(Datasets): delete records by query (#1721)
c31210d 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
frascuchon added a commit that referenced this pull request Oct 5, 2022
@frascuchon
feat(Datasets): delete records by query (#1721)
a3c4d22 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
frascuchon added a commit that referenced this pull request Oct 5, 2022
@frascuchon
feat(Datasets): delete records by query (#1721)
bc9685d 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@frascuchon