Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button enity-label gets covered by show less button #1779

Closed
davidberenstein1957 opened this issue Oct 20, 2022 · 2 comments · Fixed by #1875
Closed

Button enity-label gets covered by show less button #1779

davidberenstein1957 opened this issue Oct 20, 2022 · 2 comments · Fixed by #1875
Assignees
@leiyre
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Milestone
v1.1.0

Comments

@davidberenstein1957
Copy link
Member

Describe the bug
With a lot labels the button gets covered.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to a TokenClassification dataset
  2. Click on show more labels
  3. See error

Expected behavior
I would expect to start a new-line.

Screenshots
image

Environment (please complete the following information):

  • OS [e.g. iOS]: Mac
  • Browser [e.g. chrome, safari]: Firefox
  • Rubrix Version [e.g. 0.10.0]: 1.x
  • ElasticSearch Version [e.g. 7.10.2]: N.A.
  • Docker Image (optional) [e.g. rubrix:v0.10.0]: N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added type: bug Indicates an unexpected problem or unintended behavior app area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Oct 20, 2022
@Amelie-V
Copy link
Member

@leiyre

Since the buttons refactorization, we lost the transparency on that button.
We have at least 2 options:

  • Redo the transparency to enable read the label. (creating an exception on one button..not 100% satisfactory)
  • Start a new line. (This option will increase the high of the label caption component).
  • new 💡

@Amelie-V
Copy link
Member

Amelie-V commented Nov 8, 2022

After discussion with @leiyre , let's put it and the queue of the label list

@frascuchon frascuchon added this to the v1.1.0 milestone Nov 8, 2022
leiyre added a commit that referenced this issue Nov 8, 2022
@leiyre
fix: Move "Show less" button to the end of entities list
a3cef85 
closes #1779

This PR avoids the overlapping of the button and the entities, moving the button to the end of the list.
@leiyre leiyre mentioned this issue Nov 8, 2022
Merged
@leiyre leiyre linked a pull request Nov 14, 2022 that will close this issue
fix: Move "Show less" button to the end of entities list #1875
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

fix: Move "Show less" button to the end of entities list argilla-io/argilla
5 participants
@frascuchon @leiyre @davidberenstein1957 @Amelie-V @keithCuniah