Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide an userwarning about using underscores in hostnames #1929

Closed
davidberenstein1957 opened this issue Nov 21, 2022 · 0 comments · Fixed by #1930
Closed

feat: provide an userwarning about using underscores in hostnames #1929

davidberenstein1957 opened this issue Nov 21, 2022 · 0 comments · Fixed by #1930
Assignees
@frascuchon @davidberenstein1957
Labels
type: enhancement Indicates new feature requests
Milestone
v1.1.0

Comments

@davidberenstein1957
Copy link
Member

Is your feature request related to a problem? Please describe.
HTTPX cannot handle this during SSL verification and it is bad practice https://stackoverflow.com/questions/10959757/the-use-of-the-underscore-in-host-names

Describe the solution you'd like
A warning, when connecting to a wrong hostname.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Nov 21, 2022
davidberenstein1957 added a commit that referenced this issue Nov 21, 2022
@davidberenstein1957
feat: #1929 add warning about using wrong hostnames
ea5d0c2
@davidberenstein1957 davidberenstein1957 mentioned this issue Nov 21, 2022
Merged
@davidberenstein1957 davidberenstein1957 added this to the v1.1.0 milestone Nov 21, 2022
davidberenstein1957 added a commit that referenced this issue Nov 22, 2022
@davidberenstein1957
Merge branch 'develop' into feature/#1929-userwarning-underscore-host…
4124ad1 
…name
davidberenstein1957 added a commit that referenced this issue Nov 22, 2022
@davidberenstein1957
feat: #1929 add warning about using wrong hostnames (#1930)
a3bc554 
* feat: #1929 add warning about using wrong hostnames and added HTTPS specific check before raising a warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

@davidberenstein1957 davidberenstein1957

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat: #1929 add warning about using wrong hostnames argilla-io/argilla
2 participants
@frascuchon @davidberenstein1957