Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide more human-readable error message about upper caser in dataset name #1931

Closed
davidberenstein1957 opened this issue Nov 21, 2022 · 0 comments · Fixed by #1933
Closed

feat: provide more human-readable error message about upper caser in dataset name #1931

davidberenstein1957 opened this issue Nov 21, 2022 · 0 comments · Fixed by #1933
Assignees
@davidberenstein1957
Labels
type: enhancement Indicates new feature requests
Milestone
v1.1.0

Comments

@davidberenstein1957
Copy link
Member

davidberenstein1957 commented Nov 21, 2022 •
edited

Is your feature request related to a problem? Please describe.
A user found the message not clear enough. #1918

Describe the solution you'd like
Make the message more explicit.

Describe alternatives you've considered
N.A.

Additional context
N.A.
@davidberenstein1957 davidberenstein1957 added the type: enhancement Indicates new feature requests label Nov 21, 2022
@davidberenstein1957 davidberenstein1957 added this to the v1.1.0 milestone Nov 21, 2022
@davidberenstein1957 davidberenstein1957 self-assigned this Nov 21, 2022
@davidberenstein1957 davidberenstein1957 mentioned this issue Nov 21, 2022
Closed
@frascuchon frascuchon modified the milestones: v1.1.0, v1.2.0 Nov 21, 2022
davidberenstein1957 added a commit that referenced this issue Nov 21, 2022
@davidberenstein1957
feat: #1931 #1918 added more explicit error message regarding dataset…
ad58506 
… naming requirments
@davidberenstein1957 davidberenstein1957 mentioned this issue Nov 21, 2022
Merged
@frascuchon frascuchon modified the milestones: v1.2.0, v1.1.0 Nov 21, 2022
davidberenstein1957 added a commit that referenced this issue Nov 21, 2022
@davidberenstein1957
feat: Added more explicit error message regarding dataset name valida…
c25a225 
…tion (#1933)

feat: #1931 #1918 added more explicit error message regarding dataset naming requirments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidberenstein1957 davidberenstein1957

Labels
type: enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat: Added more explicit error message regarding dataset name validation argilla-io/argilla
2 participants
@frascuchon @davidberenstein1957