Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Client): ClassifierExplorationArea.vue pass only the necesarry data #2145

Merged
merged 3 commits into from Jan 9, 2023

Conversation

keithCuniah
Copy link
Contributor

@keithCuniah keithCuniah commented Jan 5, 2023

Description

ref : #2142
Instead of passing all the dataset, only the necessary data is passed through props into the ClassifierExplorationArea.vue

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    How Has This Been Tested

Please describe the tests that you ran to verify your changes. And ideally reference tests.

  • multilabel
  • singlelabel

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I added comments to my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@keithCuniah keithCuniah merged commit cef0aae into develop Jan 9, 2023
@keithCuniah keithCuniah deleted the feature/refactoring-ClassifierExplorationArea branch January 9, 2023 10:55
@frascuchon frascuchon added this to the v1.2.0 milestone Jan 11, 2023
@frascuchon frascuchon removed this from the v1.2.0 milestone Jan 12, 2023
keithCuniah added a commit that referenced this pull request Jan 20, 2023
# Description
this pull request is to solved conflict after merging from Similarity
search feature and to update parents components from theses components

The previous PR are:
- [x] #2143 
- [x] #2145 
- [x] #2147 
- [x] #2159


Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

refs #2142  
**This PR is link to the record parts not the header refactoring**


**Type of change**

Please delete options that are not relevant.
- [x] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

**How Has This Been Tested**

Please describe the tests that you ran to verify your changes. And
ideally reference `tests`.

- [x] multi label
- [x] single label
- [x] TextClassification
- [x] TokenClassification
- [x] Text2Text

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] I added comments to my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works

Co-authored-by: keithCuniah <keithcuniah@gmail.comh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants