feat(Client): RecordTextClassification pass only the necessary data nstead of all the dataset #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 5, 2023 18:00
…nstead of all the dataset
…it fails the test)
… pass only the necessary data
…o the RecordTextClassification component && compute the record from the props recordId
18 tasks
keithCuniah
added a commit
that referenced
this pull request
Jan 20, 2023
# Description this pull request is to solved conflict after merging from Similarity search feature and to update parents components from theses components The previous PR are: - [x] #2143 - [x] #2145 - [x] #2147 - [x] #2159 Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. refs #2142 **This PR is link to the record parts not the header refactoring** **Type of change** Please delete options that are not relevant. - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) **How Has This Been Tested** Please describe the tests that you ran to verify your changes. And ideally reference `tests`. - [x] multi label - [x] single label - [x] TextClassification - [x] TokenClassification - [x] Text2Text **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [x] I added comments to my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works Co-authored-by: keithCuniah <keithcuniah@gmail.comh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref : #2142
Instead of passing all the dataset, only the necessary data is passed through props into the RecordTextClassification component
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. And ideally reference
tests.Checklist