Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#905): copy dataset with rules #948

Merged
merged 2 commits into from Jan 13, 2022
Merged

fix(#905): copy dataset with rules #948

merged 2 commits into from Jan 13, 2022

Conversation

frascuchon
Copy link
Member

Closes #905

@frascuchon frascuchon changed the title fix: copy dataset with rules fix(#905): copy dataset with rules Jan 13, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #948 (3a9e0f6) into master (b7526c0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         109      109           
  Lines        4208     4209    +1     
=======================================
+ Hits         4019     4020    +1     
  Misses        189      189
Flag Coverage Δ
pytest 95.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/datasets/dao.py 97.77% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7526c0...3a9e0f6. Read the comment docs.

Release automation moved this from In progress to Reviewer approved Jan 13, 2022
@frascuchon frascuchon merged commit 70503ff into master Jan 13, 2022
Release automation moved this from Reviewer approved to Done Jan 13, 2022
@frascuchon frascuchon deleted the bugfixes/copy-dataset-with-rules branch January 13, 2022 13:07
@frascuchon frascuchon removed this from Done in Release Jan 18, 2022
frascuchon added a commit that referenced this pull request Jan 19, 2022
@frascuchon
fix(#905): copy dataset with rules (#948)
8597b83 
* fix: copy dataset with defined rules

* add missing tests

(cherry picked from commit 70503ff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcfidalgo dcfidalgo dcfidalgo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Rules] Rules should been copied when copy a dataset
2 participants
@frascuchon @dcfidalgo