Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Weak supervision] Rules numbers by label #961

Closed
Amelie-V opened this issue Jan 14, 2022 · 9 comments · Fixed by #1377 or #1408
Closed

[Weak supervision] Rules numbers by label #961

Amelie-V opened this issue Jan 14, 2022 · 9 comments · Fixed by #1377 or #1408
Assignees
@leiyre @Amelie-V
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Projects
Release

Comments

@Amelie-V
Copy link
Member

For instance:

Sci/tech 2
Sports 1
Business 4
Politics 0
World 0

his feature could be used for two things:

  • Help to know how is going the rule definition
  • See the full label list (in "define rules" we dont have this list by default)
@Amelie-V Amelie-V self-assigned this Jan 14, 2022
@Amelie-V Amelie-V added this to To do in Release via automation Jan 17, 2022
@frascuchon frascuchon moved this from Backlog to Planified in Release Feb 15, 2022
@Amelie-V Amelie-V moved this from Planified to In progress in Release Mar 16, 2022
@Amelie-V Amelie-V moved this from In progress to Planified in Release Mar 16, 2022
@frascuchon
Copy link
Member

@Amelie-V Is this issue the same that #880 ? Can we close one of them?

@frascuchon frascuchon added the area: ui Indicates that an issue or pull request is related to the User Interface (UI) label Mar 31, 2022
@leiyre leiyre mentioned this issue Apr 4, 2022
Merged
@frascuchon frascuchon moved this from Planified to In progress in Release Apr 4, 2022
@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 5, 2022 •
edited by leiyre

Right panel

  • Disabel tooltip on icon after click
  • Add Grey BG on hover/active states Icon mode (Explore, Annotate,Rules)
  • Review color progress bar (tooltip color = progress color, BG bar is a % of progress color)
  • Review spaces between Title and progress bar (check UI)
  • Add animation to labels counter to allow user see live the impact on creating rules on rule counter
  • Animation enhancement (WIP)
  • UI navigation component enhancement (open/close) (WIP)

@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 5, 2022

Captura de pantalla 2022-04-05 a las 15 52 34

@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 6, 2022 •
edited

QA

  • user icon should be aligned with other panel icons (If necessary increase a bit the width sidebar, to avoid problem with user modal)
  • Move the panel 1px down (it's not aligned with blue header)
  • Panel sidebar should open over pagination.
  • Could you pliz reduce the shadow effect on the right-side panel?

Next iteration

  • Add expand effect animation on panel
  • Add animation on "chevron" (panel closing)

@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 6, 2022

Captura de pantalla 2022-04-06 a las 15 21 04

Captura de pantalla 2022-04-06 a las 15 20 31

@frascuchon frascuchon moved this from In progress to Ready to DEV QA in Release Apr 7, 2022
frascuchon pushed a commit that referenced this issue Apr 7, 2022
@leiyre
feat(#961): rules metrics in sidebar (#1377)
a26a910
@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 8, 2022 •
edited by leiyre

  • It misses the Grey BG on hover states on all sidebar icons
  • Record/page selector had lost it's correct position

@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 8, 2022

Captura de pantalla 2022-04-08 a las 11 54 01

leiyre added a commit that referenced this issue Apr 8, 2022
@leiyre
fix(#961): styles after new sidebar qa
c161b30 
fix #961
This PR fixes pagination position and includes hover style in sidebar buttons
@leiyre leiyre mentioned this issue Apr 8, 2022
Closed
@frascuchon frascuchon reopened this Apr 8, 2022
Release automation moved this from Ready to DEV QA to In progress Apr 8, 2022
leiyre added a commit that referenced this issue Apr 12, 2022
@leiyre
feat(#961): include sidebar metrics animation
51af681 
see #961
@leiyre leiyre mentioned this issue Apr 12, 2022
Merged
@Amelie-V
Copy link
Member Author

Amelie-V commented Apr 13, 2022 •
edited by leiyre

(Animation review : pending)

  • Bring to front the right panel (view screenshot 1024) UPDATE: see Broken UI element Viewport 1024 #1407
  • Move the panel 1px down (it's not aligned with blue header): it's better, but the panel should not have border frame, this very light but we can distinguish it on the SS. @leiyre maybe you will fix it with the animation panel enhancement

@Amelie-V
Copy link
Member Author

Captura de pantalla 2022-04-13 a las 10 16 05

@frascuchon frascuchon linked a pull request Apr 19, 2022 that will close this issue
feat(#961): include sidebar metrics animation #1408
Merged
@frascuchon frascuchon moved this from In progress to Pending Review in Release Apr 20, 2022
@frascuchon frascuchon moved this from Pending Review to In progress in Release Apr 26, 2022
@leiyre leiyre moved this from In progress to Pending Review in Release Apr 26, 2022
@frascuchon frascuchon moved this from Pending Review to In progress in Release Apr 28, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Apr 28, 2022
Release automation moved this from Pending Review to Waiting Release Apr 29, 2022
@frascuchon frascuchon reopened this Apr 29, 2022
Release automation moved this from Waiting Release to In progress Apr 29, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Apr 29, 2022
Release automation moved this from Pending Review to Waiting Release Apr 29, 2022
frascuchon pushed a commit that referenced this issue Apr 29, 2022
@leiyre
feat(#961): include sidebar metrics animation (#1408)
a775889
@frascuchon frascuchon moved this from Waiting Release to Ready to Release QA in Release May 4, 2022
frascuchon pushed a commit that referenced this issue May 4, 2022
@leiyre @frascuchon
feat(#961): rules metrics in sidebar (#1377)
fe556c4 
(cherry picked from commit a26a910)

- include sidebar metrics animation (#1408)
(cherry picked from commit a775889)
leiyre added a commit that referenced this issue May 5, 2022
@leiyre
fix(#961): include animation delay for last progress bar track
eba3e78 
fixes #961
This PR includes a sequential animation for multiple progress bar
@leiyre leiyre mentioned this issue May 5, 2022
Closed
leiyre added a commit that referenced this issue May 5, 2022
@leiyre
fix(#961): include animation delay for last progress bar track
877dc36 
fixes #961
This PR includes a sequential animation for multiple progress bar
@leiyre leiyre mentioned this issue May 5, 2022
Merged
@Amelie-V Amelie-V moved this from Ready to Release QA to Approved Release QA in Release May 5, 2022
frascuchon pushed a commit that referenced this issue May 10, 2022
@leiyre @frascuchon
feat(#961): rules metrics in sidebar (#1377)
261f53a 
(cherry picked from commit a26a910)

- include sidebar metrics animation (#1408)
(cherry picked from commit a775889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leiyre leiyre

@Amelie-V Amelie-V

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI)
Projects
No open projects
Release
Approved Release QA
Milestone
No milestone
3 participants
@frascuchon @leiyre @Amelie-V