Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NameError in ImplicitCF #2064

Closed
miguelgfierro opened this issue Feb 19, 2024 · 3 comments
Closed

[BUG] NameError in ImplicitCF #2064

miguelgfierro opened this issue Feb 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@miguelgfierro
Copy link
Collaborator

Description

2024-02-19T18:34:57.2553239Z     @pytest.mark.gpu
2024-02-19T18:34:57.2568702Z     def test_model_lightgcn(deeprec_resource_path, deeprec_config_path):
2024-02-19T18:34:57.2569997Z         data_path = os.path.join(deeprec_resource_path, "dkn")
2024-02-19T18:34:57.2571489Z         yaml_file = os.path.join(deeprec_config_path, "lightgcn.yaml")
2024-02-19T18:34:57.2572675Z         user_file = os.path.join(data_path, r"user_embeddings.csv")
2024-02-19T18:34:57.2573837Z         item_file = os.path.join(data_path, r"item_embeddings.csv")
2024-02-19T18:34:57.2574736Z     
2024-02-19T18:34:57.2575330Z         df = movielens.load_pandas_df(size="100k")
2024-02-19T18:34:57.2576298Z         train, test = python_stratified_split(df, ratio=0.75)
2024-02-19T18:34:57.2577150Z     
2024-02-19T18:34:57.2577757Z >       data = ImplicitCF(train=train, test=test)
2024-02-19T18:34:57.2578784Z E       NameError: name 'ImplicitCF' is not defined
2024-02-19T18:34:57.2579411Z 
2024-02-19T18:34:57.2580002Z tests/smoke/recommenders/recommender/test_deeprec_model.py:251: NameError

In which platform does it happen?

How do we replicate the issue?

https://github.com/recommenders-team/recommenders/actions/runs/7963399372/job/21738878728

Expected behavior (i.e. solution)

Other Comments

FYI @SimonYansenZhao this is similar to the issue we got in #2022

@miguelgfierro miguelgfierro added the bug Something isn't working label Feb 19, 2024
@miguelgfierro
Copy link
Collaborator Author

miguelgfierro commented Feb 20, 2024

  • $ pytest tests/unit/recommenders/models/test_deeprec_model.py::test_lightgcn_component_definition working with TF 2.8.4 and CUDA 11.6
  • $ pytest tests/smoke/recommenders/recommender/test_deeprec_model.py::test_model_lightgcn --disable-warnings working with TF 2.8.4 and CUDA 11.6

@miguelgfierro
Copy link
Collaborator Author

@SimonYansenZhao
Copy link
Collaborator

Resolved in #2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants