Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] TensorFlow 1.13 update #683

Closed
loomlike opened this issue Mar 26, 2019 · 9 comments
Closed

[FEATURE] TensorFlow 1.13 update #683

loomlike opened this issue Mar 26, 2019 · 9 comments
Assignees
Labels
enhancement New feature or request low priority

Comments

@loomlike
Copy link
Collaborator

Description

Update TensorFlow package version

Other Comments

Require to refactor deprecated functions and changed APIs

@loomlike loomlike added enhancement New feature or request low priority setup labels Mar 26, 2019
@loomlike loomlike self-assigned this Mar 26, 2019
@miguelgfierro
Copy link
Collaborator

We should also discuss about TF 2.0, it is still in alpha https://github.com/tensorflow/tensorflow/releases but it will have some interesting new features (and probably breaking changes)

@loomlike
Copy link
Collaborator Author

@miguelgfierro Do we want to skip 1.13 and directly move to 2.0?

We don't suffer any bugs from 1.12 and thus not sure moving from 1.12 to 1.13 would give any benefit to us. TF2.0, on the other hand, seems has attractive features as you said, e.g. NCF reference model, distributed training API and cleaner APIs.

@miguelgfierro
Copy link
Collaborator

yeah that makes sense. I wouldn't rush unless we see a big benefit, TF 2.0 could be buggy

@gramhagen
Copy link
Collaborator

yeah, it would be nice to have a branch where tf 2.0 example was built out so we could compare, ncf might be a good starting point.

@loomlike
Copy link
Collaborator Author

Btw, tested 1.13 with unit/test_tf_utils.py and smoke/test_notebooks_gpu.py and all tests got passed.

@miguelgfierro
Copy link
Collaborator

Cool, we can upgrade them

@loomlike
Copy link
Collaborator Author

@miguelgfierro TF already released 1.14 lol... and I discussed with @gramhagen about the version. We think it makes sense to just stick with the current version we have for now (1.12) since nothing has been broken nor are buggy. Also not very exciting features in .13 and .14 for us.

So we will wait until 2.0 officially released. Is that make sense?

@miguelgfierro
Copy link
Collaborator

So we will wait until 2.0 officially released. Is that make sense?

yeah that makes sense

@miguelgfierro
Copy link
Collaborator

Closing this, feel free to reopen if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

3 participants