Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NDEBUG #394

Closed
mkohlhaas opened this issue Feb 29, 2024 · 3 comments
Closed

NDEBUG #394

mkohlhaas opened this issue Feb 29, 2024 · 3 comments
Labels
enhancement

Comments

@mkohlhaas
Copy link

Could you check for NDEBUG instead of only DEBUG and _DEBUG for print functions (CGLM_DEFINE_PRINTS) et al, e.g in include/cglm/io.h?

NDEBUG is only used for MSVC in CMakeLists.txt but is actually defined in the C++ standard and so used also by every C Compiler.

Best regards!
@recp recp mentioned this issue Mar 1, 2024
Merged
@recp
Copy link
Owner

recp commented Mar 1, 2024

Hi @mkohlhaas,

Thanks for the feedback, I've just created a PR: #395

@recp
Copy link
Owner

recp commented Mar 2, 2024

The PR is merged, thanks

@recp recp closed this as completed Mar 2, 2024
@mkohlhaas
Copy link
Author

Wow! You're strict!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@recp @mkohlhaas