Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change position of the WaveView #10

Closed
TPeterW opened this issue Oct 29, 2015 · 4 comments
Closed

Change position of the WaveView #10

TPeterW opened this issue Oct 29, 2015 · 4 comments

Comments

@TPeterW
Copy link

TPeterW commented Oct 29, 2015

I love this library thank you! One thing though, how would I go about changing the position of the refresh indicator (the ball as shown below, the position doesn't change)?

screenshot 2015-10-29 21 18 29

swipeRefreshLayout.setMaxDropHeight(10);

I tried setMaxDropHeight but it doesn't work, is it the problem with newer versions?

@TPeterW
Copy link
Author

TPeterW commented Oct 29, 2015

I'm using target idk 23 and build tools 23.0.1

@TPeterW TPeterW changed the title Change position of the spinning ball Change position of the WaveView Oct 30, 2015
@amyu
Copy link
Contributor

amyu commented Nov 7, 2015

I'm sorry it is late to notice!
Please wait a minute!!!

@amyu
Copy link
Contributor

amyu commented Nov 16, 2015

Thanks @jmatsu !!!

@amyu amyu closed this as completed Nov 16, 2015
@amyu amyu reopened this Nov 24, 2015
@jmatsu
Copy link
Contributor

jmatsu commented Nov 24, 2015

@amyu
Thank you for reopening this.

@TPeterW
In WaveView#setMaxDropHeight(int height),
height represents the offset from the top of WaveSwipeRefreshLayout.
It's not from the bottom of the animated wave so the given height should be higher than the height of the animated wave.
If a shortage of height is specified, it will be ignored and the warning message will be shown on LogCat.

According to your example, you tried to set '10' as the height.
In generally, '10' is very small, so it will be ignored.
Try to set larger integer.

It's a feature, not a bug. (But I think that height represents the offset from the top of WaveSwipeRefreshLayout. is not intuitive.)

@amyu amyu closed this as completed Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants