Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set top offset for wave animation #16

Closed
MFlisar opened this issue Jan 20, 2016 · 5 comments
Closed

Set top offset for wave animation #16

MFlisar opened this issue Jan 20, 2016 · 5 comments

Comments

@MFlisar
Copy link

MFlisar commented Jan 20, 2016

I want to use the layout in fullscreen mode with transparent toolbar and statusbar, where the content is visible underneath the toolbar and statusbar. So I would need the SwipeResfreshLayout to fill the screen (because it's scrollable content fills the screen as well and is visible underneath the toolbar and statusbar), but the wave animation should start underneath the toolbar.

Is this somehow possible?

@amyu
Copy link
Contributor

amyu commented Jan 20, 2016

Thanks @MFlisar

Sorry, I have not been able to grasp the situation.
Please give source code or screenshots.

Thank you.

@MFlisar
Copy link
Author

MFlisar commented Jan 21, 2016

Here's a short video demonstrating the current behaviour that (as far as I saw) can't be solved via any setting (you see a "fullscreen" activity with transparent statusbar + transparent toolbar):

https://www.dropbox.com/s/7t3wylln19e3hq4/SCR_20160121_085905.mp4?dl=0

Desired behaviour would be to have a setting to add a padding on top to the WaveView so that it starts underneath my toolbar when the user starts swiping down... I tried to change the layout params of the internal WaveView and tried to add a padding via reflection, but actually the LayoutParams type of it does not support it...

amyu referenced this issue Jan 23, 2016
@amyu
Copy link
Contributor

amyu commented Jan 23, 2016

@MFlisar

Thank you!

dependencies {
  compile 'com.github.recruit-lifestyle:WaveSwipeRefreshLayout:1.5'
}

If you added version1.5, you can use WaveSwipeRefreshLayout#setTopOffsetWave method!

Please refer to the following
https://github.com/recruit-lifestyle/WaveSwipeRefreshLayout/blob/master/sample/src/main/java/jp/co/recruit_lifestyle/sample/MainActivity.java#L46-L52

@amyu amyu closed this as completed Jan 23, 2016
@MFlisar
Copy link
Author

MFlisar commented Jan 23, 2016

Awesome, works great, thanks

@amyu
Copy link
Contributor

amyu commented Jan 23, 2016

It was the urgent implementation.
Please contact us if there is a bug ლ(´ڡ`ლ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants