/
RemoveDeadReturnRector.php
106 lines (101 loc) · 2.64 KB
/
RemoveDeadReturnRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
<?php
declare (strict_types=1);
namespace Rector\DeadCode\Rector\FunctionLike;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Else_;
use PhpParser\Node\Stmt\Function_;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\Return_;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\DeadCode\Rector\FunctionLike\RemoveDeadReturnRector\RemoveDeadReturnRectorTest
*/
final class RemoveDeadReturnRector extends AbstractRector
{
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove last return in the functions, since does not do anything', [new CodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$shallWeDoThis = true;
if ($shallWeDoThis) {
return;
}
return;
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$shallWeDoThis = true;
if ($shallWeDoThis) {
return;
}
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [ClassMethod::class, Function_::class, Closure::class];
}
/**
* @param ClassMethod|Function_|Closure $node
*/
public function refactor(Node $node) : ?Node
{
if ($node->stmts === [] || $node->stmts === null) {
return null;
}
\end($node->stmts);
$lastStmtKey = \key($node->stmts);
\reset($node->stmts);
$lastStmt = $node->stmts[$lastStmtKey];
if ($lastStmt instanceof If_) {
if (!$this->isBareIfWithOnlyStmtEmptyReturn($lastStmt)) {
return null;
}
$lastStmt->stmts = [];
return $node;
}
if (!$lastStmt instanceof Return_) {
return null;
}
if ($lastStmt->expr instanceof Expr) {
return null;
}
unset($node->stmts[$lastStmtKey]);
return $node;
}
private function isBareIfWithOnlyStmtEmptyReturn(If_ $if) : bool
{
if ($if->else instanceof Else_) {
return \false;
}
if ($if->elseifs !== []) {
return \false;
}
if (\count($if->stmts) !== 1) {
return \false;
}
$onlyStmt = $if->stmts[0];
if (!$onlyStmt instanceof Return_) {
return \false;
}
return !$onlyStmt->expr instanceof Expr;
}
}