/
CreateFunctionToAnonymousFunctionRector.php
157 lines (155 loc) · 5.15 KB
/
CreateFunctionToAnonymousFunctionRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
<?php
declare (strict_types=1);
namespace Rector\Php72\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\BinaryOp\Concat;
use PhpParser\Node\Expr\Closure;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PhpParser\Node\Param;
use PhpParser\Node\Scalar\Encapsed;
use PhpParser\Node\Scalar\String_;
use PhpParser\Node\Stmt;
use PhpParser\Node\Stmt\Expression;
use Rector\Exception\ShouldNotHappenException;
use Rector\Php\ReservedKeywordAnalyzer;
use Rector\Php72\NodeFactory\AnonymousFunctionFactory;
use Rector\PhpParser\Parser\InlineCodeParser;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://stackoverflow.com/q/48161526/1348344 http://php.net/manual/en/migration72.deprecated.php#migration72.deprecated.create_function-function
*
* @see \Rector\Tests\Php72\Rector\FuncCall\CreateFunctionToAnonymousFunctionRector\CreateFunctionToAnonymousFunctionRectorTest
*/
final class CreateFunctionToAnonymousFunctionRector extends AbstractRector implements MinPhpVersionInterface
{
/**
* @readonly
* @var \Rector\PhpParser\Parser\InlineCodeParser
*/
private $inlineCodeParser;
/**
* @readonly
* @var \Rector\Php72\NodeFactory\AnonymousFunctionFactory
*/
private $anonymousFunctionFactory;
/**
* @readonly
* @var \Rector\Php\ReservedKeywordAnalyzer
*/
private $reservedKeywordAnalyzer;
public function __construct(InlineCodeParser $inlineCodeParser, AnonymousFunctionFactory $anonymousFunctionFactory, ReservedKeywordAnalyzer $reservedKeywordAnalyzer)
{
$this->inlineCodeParser = $inlineCodeParser;
$this->anonymousFunctionFactory = $anonymousFunctionFactory;
$this->reservedKeywordAnalyzer = $reservedKeywordAnalyzer;
}
public function provideMinPhpVersion() : int
{
return PhpVersionFeature::DEPRECATE_CREATE_FUNCTION;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Use anonymous functions instead of deprecated create_function()', [new CodeSample(<<<'CODE_SAMPLE'
class ClassWithCreateFunction
{
public function run()
{
$callable = create_function('$matches', "return '$delimiter' . strtolower(\$matches[1]);");
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class ClassWithCreateFunction
{
public function run()
{
$callable = function($matches) use ($delimiter) {
return $delimiter . strtolower($matches[1]);
};
}
}
CODE_SAMPLE
)]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
* @return Closure|null
*/
public function refactor(Node $node) : ?Node
{
if (!$this->isName($node, 'create_function')) {
return null;
}
if ($node->isFirstClassCallable()) {
return null;
}
if (\count($node->getArgs()) < 2) {
return null;
}
$firstExpr = $node->getArgs()[0]->value;
$secondExpr = $node->getArgs()[1]->value;
$params = $this->createParamsFromString($firstExpr);
$stmts = $this->parseStringToBody($secondExpr);
$refactored = $this->anonymousFunctionFactory->create($params, $stmts, null);
foreach ($refactored->uses as $key => $use) {
$variableName = $this->getName($use->var);
if ($variableName === null) {
continue;
}
if ($this->reservedKeywordAnalyzer->isNativeVariable($variableName)) {
unset($refactored->uses[$key]);
}
}
return $refactored;
}
/**
* @return Param[]
*/
private function createParamsFromString(Expr $expr) : array
{
$content = $this->inlineCodeParser->stringify($expr);
$content = '<?php $value = function(' . $content . ') {};';
$nodes = $this->inlineCodeParser->parseString($content);
/** @var Expression $expression */
$expression = $nodes[0];
/** @var Assign $assign */
$assign = $expression->expr;
$function = $assign->expr;
if (!$function instanceof Closure) {
throw new ShouldNotHappenException();
}
return $function->params;
}
/**
* @return Stmt[]
*/
private function parseStringToBody(Expr $expr) : array
{
if (!$expr instanceof String_ && !$expr instanceof Encapsed && !$expr instanceof Concat) {
// special case of code elsewhere
return [$this->createEval($expr)];
}
$content = $this->inlineCodeParser->stringify($expr);
return $this->inlineCodeParser->parseString($content);
}
private function createEval(Expr $expr) : Expression
{
$evalFuncCall = new FuncCall(new Name('eval'), [new Arg($expr)]);
return new Expression($evalFuncCall);
}
}