ReturnTypeFromStrictNewArrayRector: missing array return type - part 2

[staabm]

Bug Report

similar to #8183 I would expect rector to add a array return type in

https://getrector.com/demo/aed924b0-d4e6-4522-a0f2-d8a5034ca416

only difference is the added block

        if (count($offers) == 0) {
            return [];
        }

[samsonasik]

ReturnTypeFromStrictNewArrayRector seems designed for only returns once instead of multiple returns and only return variable of assigned to array;

rector/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictNewArrayRector.php

Lines 106 to 112 in 51c70b1

	$returns = $this->betterNodeFinder->findInstancesOfInFunctionLikeScoped($node, Return_::class);
	if (\count($returns) !== 1) {
	return null;
	}
	if ($this->isVariableOverriddenWithNonArray($node, $variable)) {
	return null;
	}

[staabm]

if we would widen the scope to 1 dynamic array return and n-constant array/null-returns, we could support the initial snippet and additionally things like https://getrector.com/demo/c74af6a5-bc6a-479d-8469-cb3a2e56dd5a

[samsonasik]

For union nullable, I think that can use ReturnUnionTypeRector https://getrector.com/demo/8154c1f5-8db4-4a8e-949a-b38b31042c9c

[samsonasik]

@staabm ReturnTypeFromStrictNewArrayRector seems only cover Variable, while for possible return array, It is on ReturnTypeFromReturnDirectArrayRector, the ReturnTypeFromReturnDirectArrayRector doesn't support variable return tho, so it is possible improvement for fallback support of the 2 rules.

[staabm]

I don't mind which of the rules gets able to resolve my initial snippet :-) - getting support the mentioned cases would be awesome