Multiple rule configurations with the same class name as identifier

[simonschaufi]

Bug Report

Subject	Details
Rector version	any

We have several rule configurations that are loaded depending on the TYPO3 version. Each can potentially rename classes with the RenameClassConstFetchRector. Because the method $rectorConfig->ruleWithConfiguration can only register ONE configuration with one class name, any configuration loaded for older versions is ignored as it is overwritten with the last one.

Minimal PHP Code Causing Issue

File 1:

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->import(__DIR__ . '/../config.php');

    $rectorConfig->ruleWithConfiguration(
        RenameClassConstFetchRector::class,
        [
            new RenameClassAndConstFetch(
                'OldClass1',
                'NOTICE',
                'NewClass1',
                'NOTICE'
            ),
        ]
    );
};

File 2:

return static function (RectorConfig $rectorConfig): void {
    $rectorConfig->import(__DIR__ . '/../config.php');

    $rectorConfig->ruleWithConfiguration(
        RenameClassConstFetchRector::class,
        [
            new RenameClassAndConstFetch(
                'OldClass2',
                'NOTICE',
                'NewClass2',
                'NOTICE'
            ),
        ]
    );
};

Expected Behaviour

Both rules should be applied but only the constants from OldClass2 are replaced.

[samsonasik]

it seems working with single file config https://getrector.com/demo/d34bd8c2-6203-4b6e-832f-b4775c7ba0c0

could you create simple reproducible repo for it? Thank you.

[samsonasik]

I created e2e test for it at PR:

• Add e2e import 2 configs merge rector rule config rector-src#5765

it seems working ok.

[simonschaufi]

Thank you for creating a test for it. It seams to be working fine. We had a problem in our TYPO3 Rector project but probably that was before the 1.0 release of Rector with the Symfony DI Container. With the Laravel Container it seams to work fine.

I'll talk again in the team if somebody still has an issue and will let you know.

[samsonasik]

Ok, closing then ;)