Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation for FinalizeTestCaseClassRector #8616

Closed
DerpgonCz opened this issue Apr 30, 2024 · 1 comment · Fixed by rectorphp/rector-src#5850
Closed

Wrong documentation for FinalizeTestCaseClassRector #8616

DerpgonCz opened this issue Apr 30, 2024 · 1 comment · Fixed by rectorphp/rector-src#5850

Comments

@DerpgonCz
Copy link

Bug Report

Subject Details
Rector version 1.0.4

Issue

The documentation (https://github.com/rectorphp/rector/blob/main/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php) clearly shows how the code is edited. It adds the final keyword before a use statement, however the real behavior is adding the final keyword before the class keyword.

This confused me at first as I was wondering if this is a new feature.

Expected Behaviour

The documentation should show adding the keyword before the class keyword, not the use keyword.

This could also be a bug with the existing code, but I am not sure as I do not understand these constructs.

@samsonasik
Copy link
Member

Could you try provide a patch PR? You can edit https://github.com/rectorphp/rector-src/blob/cc4b63fe261a39b55b621e426d87346042412741/rules/Privatization/Rector/Class_/FinalizeTestCaseClassRector.php#L41 and run composer docs to regenerate docs

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants